vmpstr@chromium.org PTL Thanks!

This is missing a raster invalidation when the effect alias node's parent changes.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1504ddd4db783b8ec999cf9b7c36e61c969ede6c

commit 1504ddd4db783b8ec999cf9b7c36e61c969ede6c
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Wed Dec 19 22:21:08 2018

[IsolationNodes]: Ensure to generate raster invalidation on effect parent changes.

This patch ensures that when an aliased effect node's parent changes, we
detect that in the EffectPaintPropertyNode::Changed for the purposes
of generating an appropriate raster invalidation.

R=pdr@chromium.org, wangxianzhu@chromium.org

Bug:  916510 
Change-Id: Ic46df93218eed21a5e868a22cbe72a7c5763aba7
Reviewed-on: https://chromium-review.googlesource.com/c/1384661
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617977}
[modify] https://crrev.com/1504ddd4db783b8ec999cf9b7c36e61c969ede6c/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
[modify] https://crrev.com/1504ddd4db783b8ec999cf9b7c36e61c969ede6c/third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc

The patch in #5 should fix this. I'm going to let it sit in canary for a few days and then request a merge to 72. Not sure if that will get approved though.

I applied this patch and it's work. Thanks a lot!
I think it really matters - in our case it was really noticeable and strange artifacts.

This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Thanks for the fix vmpstr@ - how safe is this merge overall? Any chances this could introduce any new regressions?

I think the benefit of fixing this bug outweighs the risk (which I estimate is low).

+pdr, what do you think?

I agree that this would be good to merge. The change, while not completely trivial, is a straightforward simplification.

Thanks for feedback. Approving merge for M72, branch:3626. 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e596aca0c12d4395d1a1334723f010c5796784a2

commit e596aca0c12d4395d1a1334723f010c5796784a2
Author: Vladimir Levin <vmpstr@chromium.org>
Date: Wed Jan 02 21:41:23 2019

[IsolationNodes]: Ensure to generate raster invalidation on effect parent changes.

This patch ensures that when an aliased effect node's parent changes, we
detect that in the EffectPaintPropertyNode::Changed for the purposes
of generating an appropriate raster invalidation.

R=pdr@chromium.org, wangxianzhu@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit 1504ddd4db783b8ec999cf9b7c36e61c969ede6c)

Bug:  916510 
Change-Id: Ic46df93218eed21a5e868a22cbe72a7c5763aba7
Reviewed-on: https://chromium-review.googlesource.com/c/1384661
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617977}
Reviewed-on: https://chromium-review.googlesource.com/c/1393455
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#541}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/e596aca0c12d4395d1a1334723f010c5796784a2/third_party/blink/renderer/platform/graphics/paint/effect_paint_property_node.cc
[modify] https://crrev.com/e596aca0c12d4395d1a1334723f010c5796784a2/third_party/blink/renderer/platform/graphics/paint/raster_invalidator_test.cc

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/e596aca0c12d4395d1a1334723f010c5796784a2

Commit: e596aca0c12d4395d1a1334723f010c5796784a2
Author: vmpstr@chromium.org
Commiter: vmpstr@chromium.org
Date: 2019-01-02 21:41:23 +0000 UTC

[IsolationNodes]: Ensure to generate raster invalidation on effect parent changes.

This patch ensures that when an aliased effect node's parent changes, we
detect that in the EffectPaintPropertyNode::Changed for the purposes
of generating an appropriate raster invalidation.

R=pdr@chromium.org, wangxianzhu@chromium.org
TBR=vmpstr@chromium.org

(cherry picked from commit 1504ddd4db783b8ec999cf9b7c36e61c969ede6c)

Bug:  916510 
Change-Id: Ic46df93218eed21a5e868a22cbe72a7c5763aba7
Reviewed-on: https://chromium-review.googlesource.com/c/1384661
Reviewed-by: Philip Rogers <pdr@chromium.org>
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: vmpstr <vmpstr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617977}
Reviewed-on: https://chromium-review.googlesource.com/c/1393455
Reviewed-by: vmpstr <vmpstr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#541}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}