Issue metadata
Sign in to add a comment
|
Regression: Unnecessary grey focus highlight stays over wrench menu after closing 'Cast' overlay |
||||||||||||||||||||||
Issue descriptionChrome version: 73.0.3645.0 (Official Build) Revision b2e486f0d5a83d34bd6bdd72ebbe2005063a8133-refs/branch-heads/3645@{#1} (32/64 bit) OS: Windows (7, 8, 8.1, 10) and Linux (14.04 LTS) What steps will reproduce the problem? (1) Launch chrome, open wrench menu and click on 'Cast...' option. (2) Now close the Cast overlay and Observe focus on the wrench menu. Actual Result: Unnecessary grey focus highlight stays over wrench menu after closing 'Cast' overlay. Expected Result: Grey focus highlight should not stay over wrench menu after closing 'Cast' overlay. This is a regression issue broken in ‘M-73’, below is the Manual Regression range: Good build: 73.0.3643.0 (Revision: 617033) Bad build: 73.0.3644.0 (Revision: 617389) [Unable to provide bisect using 1) Per-revision script as Traceback error message is thrown and 2) Chromium bisect script as "File is not a zip file" error is thrown. Hence, providing suspect manually.] CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/73.0.3643.0..73.0.3644.0?pretty=fuller&n=10000 Suspecting: 617290 ?? @dfried: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. NOTE: Issue is not seen on Mac (10.13.1, 10.13.6, 10.14.3) OS. Kindly refer the attached screen-cast. Thank You..!!
,
Dec 19
The highlight on the app menu button appears to be the accessibility focus (half-grey instead of full highlight) in your example, and it's there even before the menu is opened. Are you using F6+TAB to highlight the button? Also I am unable to reproduce even using F6+TAB to access the button, and even with the old (non-views) Cast dialog. It's possible this was a side-effect of issue #916687 , which I am fixing now.
,
Dec 19
If anyone can provide reliable reproduction steps, please let me know!
,
Dec 19
Bouncing to QA to see if we can get some more information. Thanks, guys!
,
Dec 20
Update: With respect to comment #4, @dfried: There is no need of using 'F6+TAB' key to get focus over app menu initially. Providing below steps again: Steps: 1. Launch chrome, open wrench menu and click on 'Cast...' option. 2. Now close the Cast overlay and Observe focus on the wrench menu. Actual Result: Unnecessary Accessibility focus highlight stays over App menu after closing Cast overlay. Expected Result: Accessibility focus highlight should not stay over wrench menu after closing 'Cast' overlay. If focus staying on app menu is intended then, app menu should open on pressing 'Enter' or 'Space' key. Please refer the attached screen-cast. Thank You..!!
,
Dec 20
Figured out how to reproduce. Will take a look.
,
Dec 20
,
Dec 20
This bug is associated with an obsolete Cast dialog and does not reproduce with the new Views-based Cast dialog (see issue #754101 for launch bug) being rolled out in M71. Therefore I am closing this bug. |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by dfried@chromium.org
, Dec 19