New issue
Advanced search Search tips

Issue 916493 link

Starred by 2 users

Issue metadata

Status: Unconfirmed
Owner: ----
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 2
Type: Feature



Sign in to add a comment

generate_compdb.py - option to include header files and support jumbo build

Reported by i...@vivaldi.com, Dec 19

Issue description

UserAgent: Mozilla/5.0 (X11; Linux x86_64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/71.0.3578.85 Safari/537.36 Vivaldi/2.2.1388.34

Steps to reproduce the problem:
The tool tools/clang/scripts/generate_compdb.py to generate compile_commands.json database does not support jumbo builds or has no option to include the header files. As such code navigation and completion features for various IDE that depends on this database works poorly if at all when using jumbo builds or when editing a header file. 

What is the expected behavior?
The output of generate_compdb.py should include all sources even when a jumbo build is used and there should be an option to include header files into it.

What went wrong?
The tools uses ninja -t compdb to generate compile_commands.json. That does not contain the include files or, when the jumbo build is activated, most of Chromium sources as with jumbo build the sources are included into jumbo files and the database contains the entries only for these jumbo files, not the original sources.  

Did this work before? No 

Chrome version: 72  Channel: dev
OS Version: Ubuntu 18.04
Flash Version:
 
The implementation

Add option to add include files to compile_commands.json and support
jumbo builds with generate_compdb.py. The code uses ninja -t deps
to find all relevant sources and headers and add them to
compile_commands.json when necessary.


916493-jumbo-compdb.patch
5.0 KB Download
Components: Build
Labels: Needs-Triage-M71

Sign in to add a comment