Unable to upload CLs to Gerrit: internal server error: Error inserting change/patchset |
||||||||
Issue descriptionSee e.g. https://ci.chromium.org/p/infra/builders/luci.infra.cron/wpt-importer/b8926717656113533872: Traceback (most recent call last): File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/wpt_import.py", line 26, in <module> main() File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/wpt_import.py", line 19, in main host.exit(importer.main()) File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 170, in main self._upload_cl() File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/blinkpy/w3c/test_importer.py", line 477, in _upload_cl '--cc', 'robertma@chromium.org', File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/blinkpy/common/net/git_cl.py", line 60, in run return self._host.executive.run_command(command, cwd=self._cwd) File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 350, in run_command (error_handler or self.default_error_handler)(script_error) File "/b/swarming/w/ir/kitchen-workdir/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 257, in default_error_handler raise error blinkpy.common.system.executive.ScriptError: Failed to run "['git', 'cl', 'upload', '-f', '--gerrit', '--message-file', '/b/swarming/w/ir/tmp/t/tmpajw6GC', '--tbrs', u'raphael.kubo.da.costa', '--cc', 'robertma@chromium.org']" exit_code: 1 output: Last 500 characters of output: es: new: 1 (-) error: RPC failed; curl 28 Operation too slow. Less than 1000 bytes/sec transferred the last 300 seconds fatal: The remote end hung up unexpectedly fatal: The remote end hung up unexpectedly
,
Dec 19
I can reproduce the issue locally. The CL is a bit large (but still within the common range of import CLs), with 89 files changed, 169765 insertions(+), 168239 deletions(-). `git cl upload` gives: remote: Processing changes: new: 1, done remote: remote: SUCCESS remote: remote: New Changes: remote: https://chromium-review.googlesource.com/c/chromium/src/+/1384648 Import wpt@41e17ed5e95166373ab692dd7667e826e9331abc [WIP] To https://chromium.googlesource.com/chromium/src.git ! [remote rejected] b0faa7c4d82c06ec092b626ff0a635c7145994de -> refs/for/refs/heads/master%wip,m=Initial_upload,r=raphael.kubo.da.costa,cc=blink-reviews-w3ctests@chromium.org,cc=blink-reviews@chromium.org,cc=chromium-reviews@chromium.org,cc=fuzzing@chromium.org,cc=robertma@chromium.org,l=Code-Review+1 (internal server error: Error inserting change/patchset) error: failed to push some refs to 'https://chromium.googlesource.com/chromium/src.git' Sending this to the trooper queue.
,
Dec 19
After a while, a previous attempt showed up on my Gerrit dashboard: https://chromium-review.googlesource.com/c/chromium/src/+/1384609 but it's taking forever to load.
,
Dec 19
,
Dec 19
In case it matters, the final patch generated by either `git diff' or `git format-patch' is around 18M in size. The changes to the tests themselves are 89kb, so the huge majority of that size comes from the diff for third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
,
Dec 19
Not really a fix for the infra side of the issue, but I'm pretty sure https://chromium-review.googlesource.com/c/chromium/src/+/1383121 is why the diff got so big in the first place: pretty much all lines in WPT_BASE_MANIFEST_5.json now have a trailing whitespace character at the end.
,
Dec 19
Specifically, this bit from the upstream change is to blame: https://github.com/web-platform-tests/wpt/commit/1ca46e0bec3da78ea11a824f7e6d07755e1f8399#diff-2a239eec150d25cf7486394513fb1e63L255
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e179e396b914798319eadb064d47ec249cbed590 commit e179e396b914798319eadb064d47ec249cbed590 Author: Robert Ma <robertma@chromium.org> Date: Wed Dec 19 20:28:12 2018 [blinkpy] Roll WPT tools again to unblock the importer Specifically, to include the following fix in WPT manifest: https://github.com/web-platform-tests/wpt/pull/14608 TBR=qyearsley Bug: 916484 Change-Id: Ia87b822e04172acc0a5ac2b0d76167030ab21a58 Reviewed-on: https://chromium-review.googlesource.com/c/1384750 Reviewed-by: Robert Ma <robertma@chromium.org> Reviewed-by: Quinten Yearsley <qyearsley@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#617929} [modify] https://crrev.com/e179e396b914798319eadb064d47ec249cbed590/third_party/blink/tools/blinkpy/third_party/README.chromium [modify] https://crrev.com/e179e396b914798319eadb064d47ec249cbed590/third_party/blink/tools/blinkpy/third_party/wpt/checkout.sh [modify] https://crrev.com/e179e396b914798319eadb064d47ec249cbed590/third_party/blink/tools/blinkpy/third_party/wpt/wpt/tools/manifest/manifest.py
,
Dec 19
The immediate issue has been worked around in the importer by reducing the size of the diff. However, the underlying issue that Gerrit fails when the diff is >10MB still remains.
,
Dec 29
,
Jan 8
As it is related to "git cl upload", switch to infra>Git.
,
Jan 10
As the immediate issue has been worked around I'm lowering the priority. As a Gerrit issue the right thing to do is to open an issue in their issue tracker for it. I've found one that I think this might be a duplicate of, http://b/113324569. Looking into that.
,
Jan 10
|
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by raphael....@intel.com
, Dec 19