Issue metadata
Sign in to add a comment
|
Regression:'App info' overlay under chrome://apps appears distorted |
||||||||||||||||||||||
Issue descriptionChrome Version : 73.0.3645.0 (Official Build) Revision b2e486f0d5a83d34bd6bdd72ebbe2005063a8133-refs/branch-heads/3645@{#1}(32/64 bit) OS : Windows (7,8,8.1,10) and Linux(14.04 LTS) OS What steps will reproduce the problem? 1. Launch chrome, navigate to chrome://apps. 2. Right click on any of the default apps present to open context menu. 3. Now click on 'App info' option and observe the overlay. Actual Result : 'App info' overlay under chrome://apps is seen distorted. Expected Result : 'App info' overlay under chrome://apps should be seen properly. This is a regression issue broken in ‘M-73’ and below is the chromium bisect info: Good Build : 73.0.3630.0 (Revision : 613369) Bad Build : 73.0.3631.0 (Revision : 613836) You are probably looking for a change made after 613597 (known good), but no later than 613609 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/7af7fdb93b1f3a8dc3d67d120a083c0a484e070a..db1eb0e9926676ec3d681158c6cafa4a3e9c3ce9 Suspecting: r613599 ? @ccameron: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Kindly refer attached screen cast. Note: 1. Issue is not reproducible on Mac OS. 2. Tried bisecting on multiple Windows and Linux machines but unable to perform per revision bisect as getting errors.Hence provided chromium bisect. Thank you
,
Dec 19
Adding release blocker label for this issue.Please reduce priority or remove if not the case. Thank You!
,
Dec 26
Friendly ping to get an update as it is marked as RBS. Thanks..!
,
Jan 3
Friendly ping! Could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Jan 4
Sorry, I don't see a good candidate to assign this to. Adding it to the GPU queue.
,
Jan 10
Gentle ping! Some one from Internals>GPU>Rasterization dev team could you please provide any update on this issue as it has been marked as a stable blocker. Thank You!
,
Jan 10
Update: Re-bisected the above issue using per-revision bisect, following is the bisect info: You are probably looking for a change made after 613602 (known good), but no later than 613603 (first known bad). CHANGE-LOG URL: The script might not always return single CL as suspect as some perf builds might get missing due to failure. https://chromium.googlesource.com/chromium/src/+log/de5b08ad02e9cf6d08910880b3c9e0d071095fd3..6cdfa8d71ae521c8e55ee8259db174f15ed849f2 Suspect: https://chromium.googlesource.com/chromium/src/+/6cdfa8d71ae521c8e55ee8259db174f15ed849f2 @dfried: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Thank you
,
Jan 10
,
Jan 10
,
Jan 11
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3be571a2a76e58d88877fcabda8c5a8c75320202 commit 3be571a2a76e58d88877fcabda8c5a8c75320202 Author: Dana Fried <dfried@chromium.org> Date: Fri Jan 11 19:53:35 2019 Remove spurious override of GetInsets() that breaks layout. Client area of views is now caluclated from GetInsets(), and the old way dialogs were using GetInsets() to mean something completely different has been fixed/changed, so there is no reason to override GetInsets() to return zero. Removing the override fixes the layout of the dialog. Bug: 916479 Change-Id: I586236a3cfadd08805a5df4f737c982102850077 Reviewed-on: https://chromium-review.googlesource.com/c/1405874 Reviewed-by: Ben Wells <benwells@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#622106} [modify] https://crrev.com/3be571a2a76e58d88877fcabda8c5a8c75320202/chrome/browser/ui/views/apps/app_info_dialog/app_info_dialog_container.cc
,
Jan 12
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by ccameron@chromium.org
, Dec 19