New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916474 link

Starred by 1 user
Status: Fixed
Owner:
kristip...@chromium.org
Closed: Dec 20
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug-Regression



Sign in to add a comment

Regression: Unable to change writing direction to 'Right to Left' in URL text field of NTP.

Project Member Reported by dipt...@virtusa.com, Dec 19 
Chrome Version: 73.0.3645.0 Revision b2e486f0d5a83d34bd6bdd72ebbe2005063a8133-refs/branch-heads/3645@{#1}(32/64 bit)
OS: Windows (7, 8, 8.1, 10),Linux (14.04 LTS),Mac(10.13.1, 10.13.6, 10.14.3)

Pre-condition: Enabled 'Enable using the Google local NTP' and 'New Tab Page Custom Links' flag from chrome://flags

What steps will reproduce the problem?
(1) Launch chrome, open NTP and click on 'Add to Shortcut' button.
(2) Right click on URL text field and select writing direction to 'Right to Left' 
(3) Observe

Actual: Unable to change writing direction to 'Right to Left' in URL text field of NTP.

Expected: Should be able to change writing direction to 'Right to Left' in URL text field of NTP.


This is a regression issue, broken in 'M-73', will soon update the other info:

Good Build:73.0.3629.0
Bad Build: 73.0.3630.0
Actual_Direction.mp4
660 KB View Download
Expected_Direction.mp4
425 KB View Download

Comment 1 by dipt...@virtusa.com, Dec 19

Labels: hasbisect
Owner: kristip...@chromium.org
Status: Assigned (was: Unconfirmed)
Chromium Bisect:

https://chromium.googlesource.com/chromium/src/+log/fbeab2037ec087e125447344f00eadf80c1c0f83..280480c600d6ac15b68733c778917878fd0dfc3a

Suspect: https://chromium.googlesource.com/chromium/src/+/64103b173069261a6986c13f6cd32658153cdd39

@kristipark: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thank you.

Comment 2 by kristip...@chromium.org, Dec 19

Labels: -Pri-1 Pri-3
Status: Started (was: Assigned)
The URL field should always be rendered LTR regardless of text direction (see https://url.spec.whatwg.org/#url-rendering). Text align of the field can be modified in order to simulate changing to rtl, but the incorrect option in the right click menu will still be selected. Investigating if it's possible to trick the menu into seeing that the text is rtl (even though it's not) or disabling the menu option entirely.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/74bec1eff7044287feda422c3c966eb1885c317d

commit 74bec1eff7044287feda422c3c966eb1885c317d
Author: Kristi Park <kristipark@chromium.org>
Date: Thu Dec 20 19:58:05 2018

[NTP] Set input field text direction using dir attribute

Set the text direction for input fields using the "dir" element
attribute instead of CSS "direction". This allows users to change the
writing direction from the right-click context menu if they wish to.

The URL field will still be LTR by default.

With LTR selected (default):
https://screenshot.googleplex.com/gRVdNvJ6HWR.png
https://screenshot.googleplex.com/5hwGvnZ8rRy.png
With RTL selected:
https://screenshot.googleplex.com/Brge2TxgB6h.png
https://screenshot.googleplex.com/MvZi3cnWutz.png

Bug:  916474 
Change-Id: Ie20ab4d91afc10498495998c7166f28abf0c45e3
Reviewed-on: https://chromium-review.googlesource.com/c/1385387
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Mathieu Perreault <mathp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618300}
[modify] https://crrev.com/74bec1eff7044287feda422c3c966eb1885c317d/chrome/browser/resources/local_ntp/custom_links_edit.css
[modify] https://crrev.com/74bec1eff7044287feda422c3c966eb1885c317d/chrome/browser/resources/local_ntp/custom_links_edit.html
[modify] https://crrev.com/74bec1eff7044287feda422c3c966eb1885c317d/chrome/browser/resources/local_ntp/custom_links_edit.js

Comment 4 by kristip...@chromium.org, Dec 20

Status: Fixed (was: Started)

Comment 5 by dipt...@virtusa.com, Dec 21

Labels: TE-Verified-M73 TE-Verified-73.0.3647.0
Update:

Rechecked above issue on latest canary build #73.0.3647.0 using Windows (7, 8, 8.1, 10),Linux (14.04 LTS),Mac(10.13.1, 10.13.6, 10.14.3) OS and it is fixed and working as intended.

Hence adding TE_Verified labels.

Thank you.
Fix_Actual.mp4
496 KB View Download
►

Sign in to add a comment