New issue
Advanced search Search tips

Issue 916462 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 4
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Unnecessarily omnibox shifts downwards on opening 'Cast' overlay.

Reported by rp...@virtusa.com, Dec 19

Issue description

Chrome Version: 73.0.3645.0 (Official Build) Revision b2e486f0d5a83d34bd6bdd72ebbe2005063a8133-refs/branch-heads/3645@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10),Mac OS X(10.14.2,10.13.1,10.13.6)and Linux(14.04 LTs).
             
Steps to reproduce:
1. Launch chrome, navigate to NTP and right click on page to open context menu
2. Now select 'Cast' from context menu items such as cast icon appears near omnibox and observe omnibox

Actual Result: Unnecessarily omnibox shifts downwards on opening 'Cast' overlay
Expected Result: Omnibox should not shift downwards on opening 'Cast' overlay

This is a regression issue, broken in 'M-73', and will soon update other info :
Good Build:73.0.3643.0 (Revision:617033)
Bad Build: 73.0.3644.0 (Revision:617389)


 
Actual_video.mov
2.0 MB View Download
Expected_video.mov
1.8 MB View Download
Owner: dfried@chromium.org
Status: Assigned (was: Unconfirmed)
Change-Log URL:

https://chromium.googlesource.com/chromium/src/+log/73.0.3643.0..73.0.3644.0?pretty=fuller&n=10000

Suspecting: r617290 ?

@dfried: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note:
1.Unable to provide 'per-revision' bisect as it shows "Error running the gsutil command: AccessDeniedException: 403" error message,Tried on other machines but still getting the same error again.
2.Unable to perform 'chromium bisect' script as issue is not reproducible on chromium builds, hence providing suspect through Manual change-log.

Kindly refer the attached screen-cast.
Thank You..!
Cc: dfried@chromium.org
Owner: pbos@chromium.org
This bug appears to have the same root cause as  issue #916241 , namely that the browser actions container (i.e. the extensions container) is reporting a larger vertical size than it should, and because the new layout manager actually pays attention to that, it's causing the layout to be too large.

I'm handing over to Peter, who is planning to solve all of these issues.
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/82848abbf09b0cf470a2f06a617fe681d87f7f8a

commit 82848abbf09b0cf470a2f06a617fe681d87f7f8a
Author: Peter Boström <pbos@chromium.org>
Date: Fri Jan 04 18:00:33 2019

Decrease extension button size + add spacing

This makes ToolbarActionView the same size as other toolbar buttons
instead of increasing its internal size with 4dp to accomodate for
padding between items.

This reduces the BrowserActionsContainer height by 4dp (matching its
current visual height) so it should no longer be able to push the
toolbar height. It also fixes some polish where the spacing left and
right of the browser actions were inadvertedly 10dp instead of 8dp.

Bug:  chromium:831393 ,  chromium:916241 ,  chromium:916462 
Change-Id: I63e5413ce187f173a5e35b40a3ec8f02a68fa09c
Reviewed-on: https://chromium-review.googlesource.com/c/1394870
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619999}
[modify] https://crrev.com/82848abbf09b0cf470a2f06a617fe681d87f7f8a/chrome/browser/ui/layout_constants.cc
[modify] https://crrev.com/82848abbf09b0cf470a2f06a617fe681d87f7f8a/chrome/browser/ui/toolbar/toolbar_actions_bar.cc
[modify] https://crrev.com/82848abbf09b0cf470a2f06a617fe681d87f7f8a/chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
[modify] https://crrev.com/82848abbf09b0cf470a2f06a617fe681d87f7f8a/chrome/browser/ui/views/toolbar/browser_actions_container.cc
[modify] https://crrev.com/82848abbf09b0cf470a2f06a617fe681d87f7f8a/chrome/browser/ui/views/toolbar/browser_actions_container.h

Status: Fixed (was: Assigned)
This should be fixed now. Please validate in the next Canary. :)

Sign in to add a comment