Prompt users to run without "--no-manifest-update" when there's manifest-related error |
||
Issue description
When trying to do "git cl upload" or "git cl presubmit" I'm getting the following error:
** Presubmit ERRORS **
ScriptError raised: Failed to run "['python', '/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/wpt', 'manifest', '--work', '--tests-root', '/home/rego/checkout/chromium/src/third_party/blink/web_tests/external/wpt']" exit_code: 1
output: Last 500 characters of output:
189, in dump
for chunk in iterable:
File "/usr/lib/python2.7/json/encoder.py", line 434, in _iterencode
for chunk in _iterencode_dict(o, _current_indent_level):
File "/usr/lib/python2.7/json/encoder.py", line 408, in _iterencode_dict
for chunk in chunks:
File "/usr/lib/python2.7/json/encoder.py", line 361, in _iterencode_dict
items = sorted(dct.items(), key=lambda kv: kv[0])
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 16: ordinal not in range(128)
Traceback (most recent call last):
File "/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/web_tests/lint_test_expectations.py", line 184, in main
WPTManifest.ensure_manifest(host)
File "/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py", line 200, in ensure_manifest
WPTManifest.generate_manifest(host, wpt_path)
File "/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/w3c/wpt_manifest.py", line 214, in generate_manifest
return_stderr=True # This will also include stderr in the exception message.
File "/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 350, in run_command
(error_handler or self.default_error_handler)(script_error)
File "/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/common/system/executive.py", line 257, in default_error_handler
raise error
ScriptError: Failed to run "['python', '/home/rego/checkout/chromium/src/third_party/blink/tools/blinkpy/third_party/wpt/wpt/wpt', 'manifest', '--work', '--tests-root', '/home/rego/checkout/chromium/src/third_party/blink/web_tests/external/wpt']" exit_code: 1
output: Last 500 characters of output:
189, in dump
for chunk in iterable:
File "/usr/lib/python2.7/json/encoder.py", line 434, in _iterencode
for chunk in _iterencode_dict(o, _current_indent_level):
File "/usr/lib/python2.7/json/encoder.py", line 408, in _iterencode_dict
for chunk in chunks:
File "/usr/lib/python2.7/json/encoder.py", line 361, in _iterencode_dict
items = sorted(dct.items(), key=lambda kv: kv[0])
UnicodeDecodeError: 'ascii' codec can't decode byte 0xc3 in position 16: ordinal not in range(128)
,
Dec 19
The CL in which I'm getting the error is this one: https://chromium-review.googlesource.com/c/chromium/src/+/1383055 It adds a new test in WPT. However, it seems to work fine in a different machine, so I'm not sure what can be wrong in my machine... Maybe it's something only in my setup.
,
Dec 19
Hi Rego, first of all, have you rebased recently? If yes, could you delete your local external/wpt/MANIFEST.json and try again? My guess is that your local manifest is somehow corrupted. Please report back if the workaround works -- it's still a bug (albeit a low-priority one) if we can't recover from a corrupted manifest.
,
Dec 19
Yes I rebased this morning. And removing the MANIFEST.json file fixes the issue. I think I know now what I was doing wrong, I was running the tests with the new option "--no-manifest-update", and I guess after a rebase I should run it without it at least once. Thank you very much for the help. Feel free to close this, lower priority or whatever you want to do.
,
Dec 19
,
Dec 19
Mmmm, my theory was not good enough it seems. Removing the MANIFEST.json allowed me to run presubmit checks, however I cannot run tests yet. I'm getting the very same error I got for presubmit if I try to run some tests, even after removing the MANIFEST.json. $ rm web_tests/external/wpt/MANIFEST.json $ ./tools/run_web_tests.py -t Default/ web_tests/fast/css-grid-layout/ web_tests/external/wpt/css/css-grid/ |
||
►
Sign in to add a comment |
||
Comment 1 by raphael....@intel.com
, Dec 19Status: Assigned (was: Untriaged)