Pinned stream is closed after normal stream is closed |
||||||||||
Issue descriptionThis is found in issue https://buganizer.corp.google.com/issues/118418071 But this is a general issue. Impact: Skype web version has no audio after 10 seconds. Fix: https://chromium-review.googlesource.com/c/chromiumos/third_party/adhd/+/1379439
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/3cb652c54cab38cd52c7ae7a878894bf5d352060 commit 3cb652c54cab38cd52c7ae7a878894bf5d352060 Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Thu Dec 20 18:03:46 2018 CRAS: show pinned stream information It is useful to check whether a stream is pinned to a device. BUG= chromium:916431 TEST=cras_test_client --dump_a and see is_pinned, pinned_dev_idx. Change-Id: I0b5d85628b26fbaa96de76ca483dd45f66c5850b Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1383884 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> [modify] https://crrev.com/3cb652c54cab38cd52c7ae7a878894bf5d352060/cras/src/tests/cras_test_client.c [modify] https://crrev.com/3cb652c54cab38cd52c7ae7a878894bf5d352060/cras/src/server/audio_thread.c [modify] https://crrev.com/3cb652c54cab38cd52c7ae7a878894bf5d352060/cras/src/common/cras_types.h
,
Dec 21
,
Dec 22
Verified skype web version works fine on 11437.0 with the fix in #2 and #3. Add merge request to R71, R72.
,
Dec 22
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 24
,
Dec 26
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/baff7ec84b6fc42378590603f60b0af51b97805d commit baff7ec84b6fc42378590603f60b0af51b97805d Author: Hsin-Yu Chao <hychao@google.com> Date: Fri Dec 28 07:14:40 2018 CRAS: iodev_list - Exit idle for pin stream Commit 14327702 CRAS: iodev_list - Check if pinned device is open already added thread checking for pin stream use case and that causes bug that adding pin stream doesn't make iodev exit idle mode. BUG=b:118418071 chromium:916431 TEST=Use skype web and verify call stay connected without accidentally drop. Change-Id: I99333ca5cc85b4f8ee5a77ae4dca31455e60ef31 Reviewed-on: https://chromium-review.googlesource.com/1379439 Commit-Ready: Cheng-Yi Chiang <cychiang@chromium.org> Tested-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit 8bdb826649376a4c73dc6ae96d32e3e29989d9fb) Reviewed-on: https://chromium-review.googlesource.com/c/1391929 Commit-Queue: Cheng-Yi Chiang <cychiang@chromium.org> [modify] https://crrev.com/baff7ec84b6fc42378590603f60b0af51b97805d/cras/src/server/cras_iodev.h [modify] https://crrev.com/baff7ec84b6fc42378590603f60b0af51b97805d/cras/src/server/cras_iodev_list.c
,
Dec 28
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/third_party/adhd/+/af79a6ddaaf825956186634a8b1ce885910b44af commit af79a6ddaaf825956186634a8b1ce885910b44af Author: Cheng-Yi Chiang <cychiang@chromium.org> Date: Fri Dec 28 07:14:42 2018 CRAS: show pinned stream information It is useful to check whether a stream is pinned to a device. BUG= chromium:916431 TEST=cras_test_client --dump_a and see is_pinned, pinned_dev_idx. Change-Id: I0b5d85628b26fbaa96de76ca483dd45f66c5850b Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org> Reviewed-on: https://chromium-review.googlesource.com/1383884 Reviewed-by: Chih-Yang Hsia <paulhsia@chromium.org> Reviewed-by: Dylan Reid <dgreid@chromium.org> (cherry picked from commit 3cb652c54cab38cd52c7ae7a878894bf5d352060) Reviewed-on: https://chromium-review.googlesource.com/c/1391930 [modify] https://crrev.com/af79a6ddaaf825956186634a8b1ce885910b44af/cras/src/tests/cras_test_client.c [modify] https://crrev.com/af79a6ddaaf825956186634a8b1ce885910b44af/cras/src/server/audio_thread.c [modify] https://crrev.com/af79a6ddaaf825956186634a8b1ce885910b44af/cras/src/common/cras_types.h
,
Dec 31
This issue has been approved for a merge. Please merge the fix to any appropriate branches as soon as possible! If all merges have been completed, please remove any remaining Merge-Approved labels from this issue. Thanks for your time! To disable nags, add the Disable-Nags label. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Jan 2
,
Jan 2
The issue reported in b/118418071 was a P2 reported in October; it's not clear where the issue was first reported from the bug. Has this been bisected as a confirmed M71 regression, or did it also exist in M70 and/or earlier? Based on the labels in #2 I assume it's a M70 issue, so I'm declining the M71 merge request since this is quite late in the M71 lifecycle. Please re-request with justification otherwise for M71. Thanks
,
Jan 3
It's confirmed the bug started from M70. We see feedback only until recently because it's triggered by rare pin stream use cases. Let's wait for the fix in M72. Thanks! |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by cychiang@google.com
, Dec 19