Regression: Volume slider overlaps with play button when bringing focus on it using TAB key. |
|||
Issue descriptionChrome Version: 73.0.3645.0 (Official Build) b2e486f0d5a83d34bd6bdd72ebbe2005063a8133-refs/branch-heads/3645@{#1}(32/64 Bit). OS: Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS). Test URL: https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html What steps will reproduce the problem? 1. Launch chrome, navigate to the above test url. 2. Under 'Options' set video width to 200 and press enter. 3. Now, using TAB key bring focus on Volume icon in video screen and observe. Actual Result: Volume slider overlaps with play button when bringing focus on it using TAB key. Expected Result: Volume slider should not overlap play button. This is a regression issue, broken in M-73 series, and below is the bisect info. Good Build: 73.0.3644.0.0(Revision: 614502) Bad Build: 73.0.3645.0(Revision: 617390) Change-Log URL: https://chromium.googlesource.com/chromium/src/+log/73.0.3644.0..73.0.3645.0?pretty=fuller&n=10000 Suspecting: r617681 ? jazzhsu@ Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again) 2. Unable to perform Chromium bisect as video does not play on chromium builds. 3. Hence providing suspect manually. Kindly refer the below attached screen cast. Thank You!
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e38affff12c0c32c41a638e2617fba75e8c706a1 commit e38affff12c0c32c41a638e2617fba75e8c706a1 Author: Jazz Xu <jazzhsu@chromium.org> Date: Thu Dec 20 00:47:04 2018 [Media Controls] Fix volume slider container won't open when tab focusing volume slider/mute button Bug: 916430 Change-Id: I6081d05595547ce9f00c9c3a0fb06da4a04611c4 Reviewed-on: https://chromium-review.googlesource.com/c/1385115 Reviewed-by: Tommy Steimel <steimel@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#618041} [modify] https://crrev.com/e38affff12c0c32c41a638e2617fba75e8c706a1/third_party/blink/renderer/modules/media_controls/media_controls_impl.cc
,
Dec 20
Hi, Update: Retested the above issue on Windows(7,8,8.1,10), Mac(10.13.1, 10.13.6, 10.14.2), Linux(14.04 LTS) using latest Canary Build #73.0.3646.0 and issue is fixed. Now, Volume slider does not overlap play button. Kindly refer the below attached screen cast. Thank You!
,
Dec 20
|
|||
►
Sign in to add a comment |
|||
Comment 1 by rbasuvula@chromium.org
, Dec 19