New issue
Advanced search Search tips

Issue 916420 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task
Team-Accessibility



Sign in to add a comment

Implement minimal image annotation service

Project Member Reported by martis@chromium.org, Dec 19

Issue description

We are introducing an image annotation service (Google-internal design doc: go/chrome-image-annotation-service) to support image algorithms in Chrome.

The initial use case will be OCR for visually impaired users.

This bug will track implementation of a minimal image annotation service for OCR.
 
Status: Assigned (was: Untriaged)
Marking as assigned to martis@ so that this is removed from our bug triage process. Please feel free to assign to someone else if needed. 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/73b5a05de88683c97f0418078d797549db7d8ab9

commit 73b5a05de88683c97f0418078d797549db7d8ab9
Author: Michael Martis <martis@chromium.org>
Date: Thu Jan 10 03:42:44 2019

Basic image re-encoding for the image annotation service.

This change adds the first logic for the image annotation service: the
Image class that handles image scaling / encoding prior to transmission.

For more information, see the design doc: go/chrome-image-annotation-dd

Bug: crbug.com/916420
Change-Id: Ib383881f92a0fa5a2287ef0661d87eac92d40fdf
Reviewed-on: https://chromium-review.googlesource.com/c/1393133
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Jia Meng <jiameng@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621441}
[modify] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/chrome/browser/BUILD.gn
[modify] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/BUILD.gn
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/DEPS
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/README.md
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/cpp/BUILD.gn
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/cpp/image_processor.cc
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/cpp/image_processor.h
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/cpp/image_processor_unittest.cc
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/mojom/BUILD.gn
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/mojom/OWNERS
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/mojom/constants.mojom
[add] https://crrev.com/73b5a05de88683c97f0418078d797549db7d8ab9/services/image_annotation/public/mojom/image_annotation.mojom

Cc: amoylan@chromium.org
Project Member

Comment 4 by bugdroid1@chromium.org, Jan 16 (6 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab9292fa9d43591613adb3871ff2d39672216369

commit ab9292fa9d43591613adb3871ff2d39672216369
Author: Michael Martis <martis@chromium.org>
Date: Wed Jan 16 08:17:13 2019

Initial image annotator for the image annotation service.

This change adds the Annotator interface, its initial implementation and
unit tests. An Annotator sends image pixels to Google's image annotation
server for labeling.

For more information, see the design doc: go/chrome-image-annotation-dd

Bug: crbug.com/916420
Change-Id: Ia8d7057081e828400cc4cc9b243c3d301935133e
Reviewed-on: https://chromium-review.googlesource.com/c/1404550
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Sam McNally <sammc@chromium.org>
Reviewed-by: Martin Šrámek <msramek@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Reviewed-by: Andrew Moylan <amoylan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623152}
[modify] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/chrome/browser/BUILD.gn
[modify] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/BUILD.gn
[add] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/BUILD.gn
[modify] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/DEPS
[add] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/annotator.cc
[add] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/annotator.h
[add] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/annotator_unittest.cc
[modify] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/services/image_annotation/public/mojom/image_annotation.mojom
[modify] https://crrev.com/ab9292fa9d43591613adb3871ff2d39672216369/tools/traffic_annotation/summary/annotations.xml

Sign in to add a comment