platform_CrosDisksRename auto test fails |
||
Issue description
/tmp/test_that_results_aKpCjh/results-4-platform_CrosDisksRename/platform_CrosDisksRename.vfat [ FAILED ]
/tmp/test_that_results_aKpCjh/results-4-platform_CrosDisksRename/platform_CrosDisksRename.vfat FAIL: RenameCompleted signal not matched on "status": expected={'status': 0, 'path': '/dev/loop5'}, actual={'status': dbus.UInt32(6L), 'path': dbus.String(u'/dev/loop5')}
dosfstools was updated in 901479, which no longer provides the dosfslabel tool by default. Since dosfslabel is just symlinked to fatlabel, the fix is to update cros-disks to invoke the correct binary.
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromiumos/platform2/+/175c4e52ef35f1279aed49e3b639e905278f6db6 commit 175c4e52ef35f1279aed49e3b639e905278f6db6 Author: Anand K Mistry <amistry@chromium.org> Date: Fri Dec 21 02:06:28 2018 cros-disks: Use 'fatlabel' program to rename vfat partitions. The upgrade of the sys-fs/dosfstools package removed the dosfslabel tool. In the updated package, dosfslabel can be added as a symlink to fatlabel, so switch to fatlabel for renaming vfat. BUG= chromium:916395 TEST=platform_CrosDisks* auto tests Change-Id: I1d1b37590a4a95c5a768478c81d981e321c77ea4 Reviewed-on: https://chromium-review.googlesource.com/1383751 Commit-Ready: ChromeOS CL Exonerator Bot <chromiumos-cl-exonerator@appspot.gserviceaccount.com> Tested-by: Anand Mistry <amistry@chromium.org> Reviewed-by: Sergei Datsenko <dats@chromium.org> [modify] https://crrev.com/175c4e52ef35f1279aed49e3b639e905278f6db6/cros-disks/rename_manager.cc
,
Dec 21
|
||
►
Sign in to add a comment |
||
Comment 1 by vapier@chromium.org
, Dec 19