New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916380 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Last visit 20 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 3
Type: Bug



Sign in to add a comment

Implement app permissions for App Management

Project Member Reported by melzhang@google.com, Dec 19

Issue description

This is a tracker bug for work on the back-end app permissions implementation in the App Service.
 
Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9e3a449703bc33d8f4541d983b31b3b1856d70e4

commit 9e3a449703bc33d8f4541d983b31b3b1856d70e4
Author: Melissa Zhang <melzhang@google.com>
Date: Wed Jan 09 05:35:40 2019

Implement Permission structs and App Struct permissions for PWAs.

This CL defines the permission structs and their enum values. It also
locates PWA permissions and their values to fill the app struct with.
It then merges this data on app change in AppRegistryCache::OnApps.

BUG=916380

Change-Id: I27f9fb10c67f9719874be8ca410d07fafc2c3e0c
Reviewed-on: https://chromium-review.googlesource.com/c/1382664
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#621053}
[modify] https://crrev.com/9e3a449703bc33d8f4541d983b31b3b1856d70e4/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/9e3a449703bc33d8f4541d983b31b3b1856d70e4/chrome/services/app_service/public/cpp/app_update.cc
[modify] https://crrev.com/9e3a449703bc33d8f4541d983b31b3b1856d70e4/chrome/services/app_service/public/cpp/app_update.h
[modify] https://crrev.com/9e3a449703bc33d8f4541d983b31b3b1856d70e4/chrome/services/app_service/public/cpp/app_update_unittest.cc
[modify] https://crrev.com/9e3a449703bc33d8f4541d983b31b3b1856d70e4/chrome/services/app_service/public/mojom/types.mojom

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8

commit f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8
Author: Melissa Zhang <melzhang@google.com>
Date: Wed Jan 09 22:16:26 2019

Implement the App Service SetPermission method for PWAs.

This CL extends the Publisher class with a SetPermission function and
implements this function for PWAs. It also adds a permissions array to
the app structure. Currently, SetPermission() for built in Chrome OS
apps is unimplemented and may be added in future.

BUG=916380

Change-Id: Ieb79e32ca4c8c1e0a12728c565b5ef4a53b4f836
Reviewed-on: https://chromium-review.googlesource.com/c/1392698
Commit-Queue: Melissa Zhang <melzhang@google.com>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621327}
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/apps/app_service/built_in_chromeos_apps.cc
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/apps/app_service/built_in_chromeos_apps.h
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/apps/app_service/extension_apps.cc
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/apps/app_service/extension_apps.h
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/services/app_service/app_service_impl.cc
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/services/app_service/app_service_impl.h
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/services/app_service/app_service_impl_unittest.cc
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/services/app_service/public/mojom/app_service.mojom
[modify] https://crrev.com/f65b1b89547f1177f9c9bf8aedc0ac5bb8bc88b8/chrome/test/data/webui/app_management/app_management_browsertest.js

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/64227f4909355d450af381c3b093634ab4e0c3b0

commit 64227f4909355d450af381c3b093634ab4e0c3b0
Author: Melissa Zhang <melzhang@google.com>
Date: Wed Jan 09 22:21:41 2019

Implement the App Service SetPermission method for AppManagement

This CL defines a SetPermission() method for the WebUI to call to set app permissions.
The App Management Page Handler feeds the data through to the AppServiceProxy which
then feeds the data to the App Service to set the permission value.

BUG=916380

Change-Id: I6ad1fcfe7eb5004d6e40b29b759899a88a8cec31
Reviewed-on: https://chromium-review.googlesource.com/c/1393588
Commit-Queue: Melissa Zhang <melzhang@google.com>
Reviewed-by: Nigel Tao <nigeltao@chromium.org>
Reviewed-by: calamity <calamity@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621334}
[modify] https://crrev.com/64227f4909355d450af381c3b093634ab4e0c3b0/chrome/browser/apps/app_service/app_service_proxy.cc
[modify] https://crrev.com/64227f4909355d450af381c3b093634ab4e0c3b0/chrome/browser/apps/app_service/app_service_proxy.h
[modify] https://crrev.com/64227f4909355d450af381c3b093634ab4e0c3b0/chrome/browser/ui/webui/app_management/app_management.mojom
[modify] https://crrev.com/64227f4909355d450af381c3b093634ab4e0c3b0/chrome/browser/ui/webui/app_management/app_management_page_handler.cc
[modify] https://crrev.com/64227f4909355d450af381c3b093634ab4e0c3b0/chrome/browser/ui/webui/app_management/app_management_page_handler.h

Status: Assigned (was: Untriaged)
This issue has an owner, a component and a priority, but is still listed as untriaged or unconfirmed. By definition, this bug is triaged. Changing status to "assigned". Please reach out to me if you disagree with how I've done this.
Project Member

Comment 6 by bugdroid, Today (7 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/12eff4b61cea3d1545e3894ded9ee2c5a392d595

commit 12eff4b61cea3d1545e3894ded9ee2c5a392d595
Author: Melissa Zhang <melzhang@google.com>
Date: Tue Jan 22 23:42:08 2019

Implement App Permission Grant and Revoke for ARC apps.

This CL adds the arc bridge support and required mojo connections
such that Chrome OS can access and call the grant and revoke Android
app permission functions that are implemented on ARC.

BUG=916380

Change-Id: I1c2d788fb2da3988244b235e7d8850368010117c
Reviewed-on: https://chromium-review.googlesource.com/c/1415061
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: David Jacobo <djacobo@chromium.org>
Commit-Queue: Melissa Zhang <melzhang@google.com>
Auto-Submit: Melissa Zhang <melzhang@google.com>
Cr-Commit-Position: refs/heads/master@{#624987}
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/chrome/browser/chromeos/arc/arc_service_launcher.cc
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/BUILD.gn
[add] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/app_permissions/arc_app_permissions_bridge.cc
[add] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/app_permissions/arc_app_permissions_bridge.h
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/arc_bridge_host_impl.cc
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/arc_bridge_host_impl.h
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/arc_bridge_service.h
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/common/BUILD.gn
[add] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/common/app_permissions.mojom
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/common/arc_bridge.mojom
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/test/fake_arc_bridge_host.cc
[modify] https://crrev.com/12eff4b61cea3d1545e3894ded9ee2c5a392d595/components/arc/test/fake_arc_bridge_host.h

Sign in to add a comment