New issue
Advanced search Search tips

Issue 916379 link

Starred by 3 users
Status: Available
Owner: ----
Cc:
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug



Sign in to add a comment

BrowserKeyEventsTest.AccessKeys fails with mash

Project Member Reported by sky@chromium.org, Dec 19 
This test fails in mash because of differences in timing. In particular, in classic mode an accelerator that moves focus is processed *after* text is inserted, where as now the accelerator runs first, resulting in text going to the wrong place. The right fix likely entails updating the test for mash.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b373e9317d0985abbbdca59877ae8ad80919abef

commit b373e9317d0985abbbdca59877ae8ad80919abef
Author: Scott Violet <sky@chromium.org>
Date: Wed Dec 19 06:58:03 2018

chromeos: removes single_process_mash.interactive_ui_tests.filter file

And instead adds early outs. This way the tree will be green when we switch
SingleProcessMash on by default.

BUG= 916183 ,897879,916379
TEST=test only changes

Change-Id: I0e32837a216e02611ceb2b1454c31cf2c4defb4e
Reviewed-on: https://chromium-review.googlesource.com/c/1383124
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617746}
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/chrome/browser/extensions/extension_fullscreen_apitest.cc
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/94cbc94bffae9985b93e9b8381907726faf5efb7/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/test_suites.pyl
►

Sign in to add a comment