Issue 916376 link

Starred by 0 users

Issue metadata

Status:	Fixed
Owner:	sa...@chromium.org
Closed:	Dec 20
Components:	Platform>Apps>FileManager
EstimatedDays:	----
NextAction:	----
OS:	Chrome
Pri:	2
Type:	Bug
CrOSFilesFeature-DriveSync Treadstone Target-73

Use DriveFS-provided mime types for file tasks

Project Member Reported by sa...@chromium.org, Dec 19

Issue description

The current code for retrieving mime types for determining file tasks branches on whether the file is native or not. With DriveFS, the file is native, but the mime type should be retrieved from DriveFS, since it has mime type metadata so we don't need to guess or sniff content.

Project Member

Comment 1 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/76a513fc40cab52df1b5033044eb9a900e613bde

commit 76a513fc40cab52df1b5033044eb9a900e613bde
Author: Sam McNally <sammc@chromium.org>
Date: Thu Dec 20 04:00:59 2018

Use DriveFS-provided mime types when filtering file tasks.

Bug:  916376 
Change-Id: Ic4ec8c1a0c03528515e799369e5db0ded3260772
Reviewed-on: https://chromium-review.googlesource.com/c/1385686
Commit-Queue: Sam McNally <sammc@chromium.org>
Reviewed-by: Sergei Datsenko <dats@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618104}
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/chrome/browser/chromeos/file_manager/filesystem_api_util.cc
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/chrome/browser/chromeos/file_manager/filesystem_api_util.h
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.cc
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/chrome/browser/extensions/api/file_handlers/non_native_file_system_delegate_chromeos.h
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/extensions/browser/api/file_handlers/mime_util.cc
[modify] https://crrev.com/76a513fc40cab52df1b5033044eb9a900e613bde/extensions/browser/api/file_handlers/non_native_file_system_delegate.h

Comment 2 by sa...@chromium.org, Dec 20

Status: Fixed (was: Assigned)

►

Issue 916376 link

Issue metadata

Use DriveFS-provided mime types for file tasks

Issue description

Comment 1 by bugdroid1@chromium.org, Dec 20

Comment 1 Deleted

Comment 2 by sa...@chromium.org, Dec 20

Comment 2 Deleted

Sign in to add a comment