PiP crashes when play/paused on PiP player with in ChromeOS |
||||
Issue descriptionChrome Version: 73.0.3645.0 (Developer Build) (64-bit) OS: ChromeOS (built and ran on linux if that matters) What steps will reproduce the problem? (1) Go to https://mounirlamouri.github.io/sandbox/media/dynamic-controls.html (2) Activate PiP on video. (3) Press play on PiP window. What is the expected result? Video plays What happens instead? Crashes [149574:149574:1218/184010.015226:FATAL:picture_in_picture_window_controller_impl.cc(171)] Check failed: window_ && window_->IsActive(). #0 0x7f6bfa2c70ad base::debug::StackTrace::StackTrace() #1 0x7f6bf9fc152a base::debug::StackTrace::StackTrace() #2 0x7f6bfa02beae logging::LogMessage::~LogMessage() #3 0x7f6bf2e90cb7 content::PictureInPictureWindowControllerImpl::TogglePlayPause() #4 0x55e88b1169b4 OverlayWindowViews::TogglePlayPause() #5 0x55e88b116b80 OverlayWindowViews::ButtonPressed() #6 0x7f6be44c165b views::Button::NotifyClick() #7 0x7f6be44bfc28 views::Button::OnMouseReleased() #8 0x7f6be45d9dcc views::View::ProcessMouseReleased() #9 0x7f6be45d98b5 views::View::OnMouseEvent() #10 0x7f6beeb96365 ui::EventHandler::OnEvent() #11 0x7f6beebaeabc ui::ScopedTargetHandler::OnEvent() #12 0x7f6beeb93d4a ui::EventDispatcher::DispatchEvent() #13 0x7f6beeb92795 ui::EventDispatcher::ProcessEvent() #14 0x7f6beeb921b7 ui::EventDispatcherDelegate::DispatchEventToTarget() #15 0x7f6beeb9200e ui::EventDispatcherDelegate::DispatchEvent() #16 0x7f6be45f0278 views::internal::RootView::OnMouseReleased() #17 0x7f6be45f998f views::Widget::OnMouseEvent() #18 0x55e88b116670 OverlayWindowViews::OnMouseEvent() #19 0x7f6be46484d8 views::NativeWidgetAura::OnMouseEvent() #20 0x7f6beeb96365 ui::EventHandler::OnEvent() #21 0x7f6beeb93d4a ui::EventDispatcher::DispatchEvent() #22 0x7f6beeb92795 ui::EventDispatcher::ProcessEvent() #23 0x7f6beeb921b7 ui::EventDispatcherDelegate::DispatchEventToTarget() #24 0x7f6beeb9200e ui::EventDispatcherDelegate::DispatchEvent() #25 0x7f6beeb97905 ui::EventProcessor::OnEventFromSource() #26 0x7f6beeb97c3c ui::EventProcessor::OnEventFromSource() #27 0x7f6bc1357a5f ws::EventQueue::DeliverOrQueueEvent() #28 0x7f6be0f74518 ash::AshWindowTreeHostPlatform::DeliverEventToSink() #29 0x7f6be0f745bc ash::AshWindowTreeHostPlatform::DeliverEventToSink() #30 0x7f6beeb99786 ui::EventSource::SendEventToSinkFromRewriter() #31 0x7f6beeb98c51 ui::EventSource::SendEventToSink() #32 0x7f6beb4e9a9d aura::WindowTreeHostPlatform::DispatchEvent() #33 0x7f6be0f743f1 ash::AshWindowTreeHostPlatform::DispatchEvent() #34 0x7f6bdec56d10 _ZN4base8internal13FunctorTraitsIMN2ui22PlatformWindowDelegateEFvPNS2_5EventEEvE6InvokeIS7_PS3_JS5_EEEvT_OT0_DpOT1_ #35 0x7f6bdec56c3f _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIMN2ui22PlatformWindowDelegateEFvPNS4_5EventEEJPS5_S7_EEEvOT_DpOT0_ #36 0x7f6bdec56bd5 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE7RunImplIS8_NSt3__15tupleIJSA_EEEJLm0EEEEvOT_OT0_NSF_16integer_sequenceImJXspT1_EEEEOS6_ #37 0x7f6bdec56b09 _ZN4base8internal7InvokerINS0_9BindStateIMN2ui22PlatformWindowDelegateEFvPNS3_5EventEEJNS0_17UnretainedWrapperIS4_EEEEEFvS6_EE7RunOnceEPNS0_13BindStateBaseES6_ #38 0x7f6beebafff1 _ZNO4base12OnceCallbackIFvPN2ui5EventEEE3RunES3_ #39 0x7f6beebafe1d ui::DispatchEventFromNativeUiEvent() #40 0x7f6bded1ac4c ui::X11WindowOzone::DispatchEvent() #41 0x7f6bf81bc627 ui::PlatformEventSource::DispatchEvent() #42 0x7f6bbe744e19 ui::X11EventSourceLibevent::DispatchPlatformEvent() #43 0x7f6bbe74381a ui::X11EventSourceLibevent::ProcessXEvent() #44 0x7f6bbe732455 ui::X11EventSource::ExtractCookieDataDispatchEvent() #45 0x7f6bbe7323de ui::X11EventSource::DispatchXEvents() #46 0x7f6bbe74507f ui::X11EventSourceLibevent::OnFileCanReadWithoutBlocking() #47 0x7f6bfa3189be base::MessagePumpLibevent::FdWatchController::OnFileCanReadWithoutBlocking() #48 0x7f6bfa31a00d base::MessagePumpLibevent::OnLibeventNotification() #49 0x7f6bfa36a70e event_process_active #50 0x7f6bfa369d57 event_base_loop #51 0x7f6bfa31a449 base::MessagePumpLibevent::Run() #52 0x7f6bfa051a86 base::MessageLoopImpl::Run() #53 0x7f6bfa0fd692 base::RunLoop::Run() #54 0x55e885e9a320 ChromeBrowserMainParts::MainMessageLoopRun() #55 0x7f6bf23e9753 content::BrowserMainLoop::RunMainMessageLoopParts() #56 0x7f6bf23f1e20 content::BrowserMainRunnerImpl::Run() #57 0x7f6bf23dca5e content::BrowserMain() #58 0x7f6bf4759c50 content::RunBrowserProcessMain() #59 0x7f6bf475d0c5 content::ContentMainRunnerImpl::RunServiceManager() #60 0x7f6bf475bc89 content::ContentMainRunnerImpl::Run() #61 0x7f6bf4752a4c content::ContentServiceManagerMainDelegate::RunEmbedderProcess() #62 0x7f6bc4546431 service_manager::Main() #63 0x7f6bf4757365 content::ContentMain() #64 0x55e881ad0786 ChromeMain #65 0x55e881ad0692 main #66 0x7f6bc64442b1 __libc_start_main #67 0x55e881ad056a _start
,
Jan 2
After debugging, it happens that window_->IsActive() is false causing DCHECK crash.
bool PictureInPictureWindowControllerImpl::TogglePlayPause() {
DCHECK(window_ && window_->IsActive());
...
}
I think https://chromium-review.googlesource.com/c/chromium/src/+/1357819 is the CL where this regression was introduced.
I'll work on a patch to address this issue.
,
Jan 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/82020c5f4604a39aa5956d142f37aa3b3514af06 commit 82020c5f4604a39aa5956d142f37aa3b3514af06 Author: François Beaufort <beaufort.francois@gmail.com> Date: Thu Jan 03 18:20:16 2019 [Picture-in-Picture] Remove window.IsActive() DCHECK This CL removes window.IsActive() DCHECK in PiP window controller as this result is no longer always true anymore in Chrome OS due to https://chromium-review.googlesource.com/c/chromium/src/+/1357819. Bug: 916370 Change-Id: I1b1ff742baa76a4147f162aa620cfc5657fb8783 Reviewed-on: https://chromium-review.googlesource.com/c/1392344 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#619693} [modify] https://crrev.com/82020c5f4604a39aa5956d142f37aa3b3514af06/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc
,
Jan 4
,
Jan 7
|
||||
►
Sign in to add a comment |
||||
Comment 1 by mlamo...@google.com
, Dec 19Owner: fbeaufort@chromium.org