New issue
Advanced search Search tips

Issue 916363 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Android , Windows , Chrome , Mac
Pri: 2
Type: Task
Team-Accessibility



Sign in to add a comment

Implement client-side support for image annotation service

Project Member Reported by martis@chromium.org, Dec 19

Issue description

We are implementing an image annotation service for a11y image labeling features in Chrome. For details, see the (internal, sorry) design doc: go/chrome-image-annotation-dd

This bug tracks progress on Chrome client libraries for the service (i.e. code in components/ that communicates with the service to label page images).
 
Status: Assigned (was: Untriaged)
Marking as assigned to martis@ so that this is removed from our bug triage process. Please feel free to assign to someone else if needed. 
Project Member

Comment 2 by bugdroid1@chromium.org, Jan 9

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1a57af941a09fee6a46b965e77a2c2043997628b

commit 1a57af941a09fee6a46b965e77a2c2043997628b
Author: Michael Martis <martis@chromium.org>
Date: Wed Jan 09 22:23:55 2019

Added initial page annotator code.

This is the first class in the image annotation client library, which will
support the use of the image annotation service (see Google-internal doc
go/chrome-image-annotation-dd) for images on webpages.

The page annotator will be used to schedule and receive image annotations for
one web page. This initial CL only contains minimal observer logic; the
annotation logic (i.e. communication with the annotation service) will be added
when the service is complete.

Bug: crbug.com/916363
Change-Id: I74ff44ba707cab972866999cbe0c9542d509293d
Reviewed-on: https://chromium-review.googlesource.com/c/1383756
Reviewed-by: Avi Drissman <avi@chromium.org>
Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621336}
[modify] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/BUILD.gn
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/DEPS
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/OWNERS
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/README.md
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/content/DEPS
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/content/renderer/BUILD.gn
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/content/renderer/DEPS
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/content/renderer/content_page_annotator_driver.cc
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/content/renderer/content_page_annotator_driver.h
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/core/BUILD.gn
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/core/page_annotator.cc
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/core/page_annotator.h
[add] https://crrev.com/1a57af941a09fee6a46b965e77a2c2043997628b/components/page_image_annotation/core/page_annotator_unittest.cc

Project Member

Comment 3 by bugdroid1@chromium.org, Jan 17 (5 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9cf33c3a060d9aa21e26f130cf288f43da49266

commit c9cf33c3a060d9aa21e26f130cf288f43da49266
Author: Michael Martis <martis@chromium.org>
Date: Thu Jan 17 23:27:20 2019

Incremental updates to the page annotator.

This includes:
  - Simplifying the observer lifetime story (given the guarantees we can make
    in both Content and iOS implementations).
  - Moving more logic (image metadata and add/update multiplexing) into the
    core PageAnnotator class.
  - Instantiating client-side image annotation objects (ImageProcessors) which
    will be used in a subsequent CL.

Bug: crbug.com/916363
Change-Id: I068ea7e4e3858b072f17c13baa71efeaf503d22d
Reviewed-on: https://chromium-review.googlesource.com/c/1408689
Commit-Queue: Michael Martis <martis@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Brian Salomon <bsalomon@google.com>
Reviewed-by: Charles . <charleszhao@chromium.org>
Reviewed-by: Colin Blundell <blundell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623904}
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/BUILD.gn
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/page_image_annotation/DEPS
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/page_image_annotation/core/BUILD.gn
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/page_image_annotation/core/page_annotator.cc
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/page_image_annotation/core/page_annotator.h
[modify] https://crrev.com/c9cf33c3a060d9aa21e26f130cf288f43da49266/components/page_image_annotation/core/page_annotator_unittest.cc

Project Member

Comment 4 by bugdroid, Today (8 hours ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0dcb68e76a082252fd45e652af0a09d5112dbc6b

commit 0dcb68e76a082252fd45e652af0a09d5112dbc6b
Author: Michael Martis <martis@chromium.org>
Date: Tue Jan 22 22:04:01 2019

Page image annotation: very simple image tracking (only for prototyping)

This CL provides information about images that are added to / removed from a
page to the PageAnnotator. It does so in the least-sophisticated way possible:
by waiting for 3sec after document load (as a heuristic to let the page
stabilize) then crawling the DOM once using public Blink APIs.

This approach will be revisited / improved before feature launch, but it
is important for us to have *something* working to prototype the feature.

Since a ContentPageAnnotatorDriver is not yet instantiated, the inefficiencies
in this CL won't effect users.

Bug: crbug.com/916363
Change-Id: I0473b1f9a582c91294d74768fa3acc82cb72eb4e
Reviewed-on: https://chromium-review.googlesource.com/c/1411962
Reviewed-by: Yutaka Hirano <yhirano@chromium.org>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Charles . <charleszhao@chromium.org>
Commit-Queue: Michael Martis <martis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624952}
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/chrome/renderer/BUILD.gn
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/BUILD.gn
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/page_image_annotation/content/renderer/BUILD.gn
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/page_image_annotation/content/renderer/DEPS
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/page_image_annotation/content/renderer/content_page_annotator_driver.cc
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/page_image_annotation/content/renderer/content_page_annotator_driver.h
[add] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/components/page_image_annotation/content/renderer/content_page_annotator_driver_unittest.cc
[modify] https://crrev.com/0dcb68e76a082252fd45e652af0a09d5112dbc6b/third_party/blink/renderer/core/html/html_image_element.cc

Sign in to add a comment