New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916351 link

Starred by 1 user
Status: Fixed
Owner:
chlily@chromium.org
Closed: Dec 20
Cc:
█ dcreager@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

NetworkErrorLoggingEndToEndTest.ReportNetworkError flakily times out

Project Member Reported by thestig@chromium.org, Dec 19 
I noticed due to this red bot: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/chromeos-amd64-generic-rel/23421

Looking at the flakiness dashboard, I see the test times out frequently and often needs another try to pass. It is also skipped entirely on Windows. Can we make test more reliable?

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=net_unittests&tests=NetworkErrorLoggingEndToEndTest.ReportNetworkError

Comment 1 by jselover@chromium.org, Dec 19 

It looks like this has been noticed before on other platforms:
https://bugs.chromium.org/p/chromium/issues/detail?id=829650
We could add more platforms to the disabled list, but it might be better to just remove the test entirely at this point.

Comment 2 by jselover@chromium.org, Dec 19

Owner: chlily@chromium.org
Status: Assigned (was: Untriaged)

Comment 3 by dcreager@chromium.org, Dec 19 

I think it would be okay to remove the flaky test completely — between NEL's unit tests, reporting_browsertest, and in the WPT tests, I think we have enough coverage.
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/63585ebefa192bfa420060db04e4b7088fab7975

commit 63585ebefa192bfa420060db04e4b7088fab7975
Author: Lily Chen <chlily@chromium.org>
Date: Thu Dec 20 16:14:58 2018

Remove flaky NetworkErrorLoggingEndToEndTest

Was flakily timing out on multiple platforms, and was already disabled
for Windows and Fuchsia.

Bug:  916351 , 820950
Change-Id: Ia2b542657366f587ad3ba865e9bdcf1c1b1fbe98
Reviewed-on: https://chromium-review.googlesource.com/c/1384641
Reviewed-by: Misha Efimov <mef@chromium.org>
Commit-Queue: Lily Chen <chlily@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618231}
[modify] https://crrev.com/63585ebefa192bfa420060db04e4b7088fab7975/net/BUILD.gn
[delete] https://crrev.com/53e76c7736924adb26cc5b50320a6ae57bc0009c/net/network_error_logging/network_error_logging_end_to_end_test.cc

Comment 5 by chlily@chromium.org, Dec 20

Status: Fixed (was: Assigned)
►

Sign in to add a comment