New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916343 link

Starred by 2 users
Status: Fixed
Owner:
█ donnd@chromium.org
(OOO slow)
Closed: Dec 20
Cc:
jinsuk...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

[Ephemeral Tab] Confusing menu items for linked images

Project Member Reported by wychen@chromium.org, Dec 19 
Steps to reproduce:
* Visit https://www.bbc.com/news/uk-politics-46535739, or any web pages with images inside an anchor.
* Long click the image. For the URL above, it's the preview thumbnail in the embedded twitter.

Observed behavior: 
There are two menu items with text "*New* Sneak peek".

Expected behavior:
The first one means sneak peek for the link, and the second is for the image. Maybe we should say "*New* Sneak peek image" for the second one.


Frequency: 
Deterministic

Comment 1 by donnd@google.com, Dec 19

Labels: -Pri-3 M-73 Pri-2
I'm guessing that sometimes an image is also a link, and in this case we show both. I'll take a look at this and see what the options are.

Thanks for the bug report!

Comment 2 by donnd@chromium.org, Dec 19

Status: Started (was: Assigned)
Best to have both menu items since they do different things in cases like this.  I'll just add "image" to the image ET.
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2951371db7246a63cc3c316a9423f11dab48b0c8

commit 2951371db7246a63cc3c316a9423f11dab48b0c8
Author: Donn Denman <donnd@chromium.org>
Date: Thu Dec 20 00:40:56 2018

[Ephemeral Tab] Add "image" to the image menu item

Just adds "image" to the current menu item so it can be differentiated
from the "Sneak peek" that opens the link into a tab.

BUG= 916343 

Change-Id: Idbb916e05a6fdeca54fb832f17b842796925002d
Reviewed-on: https://chromium-review.googlesource.com/c/1385545
Reviewed-by: Jinsuk Kim <jinsukkim@chromium.org>
Commit-Queue: Donn Denman <donnd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618038}
[modify] https://crrev.com/2951371db7246a63cc3c316a9423f11dab48b0c8/chrome/android/java/strings/android_chrome_strings.grd

Comment 4 by donnd@chromium.org, Dec 20

Status: Fixed (was: Started)

Comment 5 by donnd@chromium.org, Dec 20 

Issue 917059 has been merged into this issue.
►

Sign in to add a comment