New issue
Advanced search Search tips

Issue 916340 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 20
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Build-Toolchain



Sign in to add a comment

toolchain-utils: replace page_cycler with loading.desktop in nightly tests.

Project Member Reported by cmt...@chromium.org, Dec 19

Issue description

page_cycler_v2.typical_25 is deprecated (and flaky!).  The
recommended replacement is loading.desktop@@typical.

Our nightly performance test infrastructure needs to be updated to use loading.desktop@@typical instead of page_cycler_v2.typical_25.
 
related to https://crbug.com/868755


Project Member

Comment 2 by bugdroid1@chromium.org, Dec 20

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/third_party/toolchain-utils/+/219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5

commit 219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5
Author: Caroline Tice <cmtice@google.com>
Date: Thu Dec 20 21:49:40 2018

toolchain-utils: Add loading.desktop@@typical to nightly tests.

page_cycler_v2.typical_25 is deprecated (and flaky!).  The
recommended replacement is loading.desktop@@typical.  This CL updates
our nightly performance test infrastructure to handle
loading.desktop@@typical.

BUG= chromium:916340 
TEST=Tested with nightly run on chrotomation2.

Change-Id: I6366b3a8e6a2926ad759a209cfded890e3109810
Reviewed-on: https://chromium-review.googlesource.com/1382826
Commit-Ready: Caroline Tice <cmtice@chromium.org>
Tested-by: Caroline Tice <cmtice@chromium.org>
Reviewed-by: Manoj Gupta <manojgupta@chromium.org>

[modify] https://crrev.com/219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5/crosperf/benchmark.py
[modify] https://crrev.com/219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5/buildbot_test_toolchains.py
[modify] https://crrev.com/219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5/crosperf/default-telemetry-results.json
[modify] https://crrev.com/219e3b7cbbe1d62a7e23000180bbdb3f1acdc2e5/crosperf/results_organizer.py

Status: Fixed (was: Started)

Sign in to add a comment