New issue
Advanced search Search tips

Issue 916337 link

Starred by 2 users
Status: Started
Owner:
qin...@chromium.org
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Chrome doesn't kill itself with paused download notifications

Project Member Reported by qin...@chromium.org, Dec 19 
I can repro this on all pixel devices.
1. Launch Chrome, download a file. While downloading, pause the download and swiping away chrome.
2. go to terminal and use "adb shell ps | grep chrome", and you can find that browser process is actually not killed.

Relaunch the chrome app and swiping it away will kill the process.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dec6e0f8633886da698f5e4efa6287e75d7d6b1d

commit dec6e0f8633886da698f5e4efa6287e75d7d6b1d
Author: Min Qin <qinmin@chromium.org>
Date: Wed Dec 19 18:21:11 2018

Call stopSelf() when download foreground service is stopped.

When calling DownloadForegroundService.stopForeground(), we didn't stop
the service. This causes Chrome to not kill it self when swiping away the app.
This CL fixes the issue by calling stopSelf() when calling stopForeground().
The stopped service will be restarted by calls to startForeground() later.

BUG=916337

When download notifications are no longer active (all paused, or completed/interrupted)

Change-Id: I37e3a21116a9a6d62dc8635726086e253fe77ffa
Reviewed-on: https://chromium-review.googlesource.com/c/1383494
Commit-Queue: Min Qin <qinmin@chromium.org>
Reviewed-by: Xing Liu <xingliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617882}
[modify] https://crrev.com/dec6e0f8633886da698f5e4efa6287e75d7d6b1d/chrome/android/java/src/org/chromium/chrome/browser/download/DownloadForegroundService.java
►

Sign in to add a comment