New issue
Advanced search Search tips

Issue 916332 link

Starred by 1 user
Status: Fixed
Owner:
m...@chromium.org
Closed: Dec 20
Cc:
mfo...@chromium.org
ios-bugs@chromium.org
powerb@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , iOS , Chrome , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Tab Capture doesn't recover after crashed renderer is reloaded

Project Member Reported by m...@chromium.org, Dec 19 
What steps will reproduce the problem?
(1) Use tabCapture demo extension (in extension examples in Chromium tree) to start tab capture.
(2) On tab being captured, navigate to chrome://crash
(3) Reload crashed tab.

What is the expected result?
Tab capture should resume capturing after the reload.

What happens instead?
Tab capture is frozen indefinitely, never updates again. Audio is working fine, however.

------------------------

Side note: I could swear there was a crbug filed for this already (a few weeks back), but I can't seem to locate it now.
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/19da6931af266c51af0502016fc3057e5942fac6

commit 19da6931af266c51af0502016fc3057e5942fac6
Author: Yuri Wiitala <miu@chromium.org>
Date: Wed Dec 19 09:16:34 2018

WebContentsVideoCaptureDevice resumes after crashed renderer is reloaded.

This is a regression fix. The fix itself is literally a one-line code
change. However, the problem has highlighted the need for additional
testing to prevent future breakage. Thus, this change includes two new
content_browsertests to: 1) ensure this regression fix holds; 2) test
that the general "re-targetting" logic works for the other non-crash
navigation use cases.

Bug:  916332 
Change-Id: I4ec2e95d77c3b19fa7e9c44e24200f05bee4d2d2
Reviewed-on: https://chromium-review.googlesource.com/c/1383217
Reviewed-by: Takumi Fujimoto <takumif@chromium.org>
Commit-Queue: Yuri Wiitala <miu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617776}
[modify] https://crrev.com/19da6931af266c51af0502016fc3057e5942fac6/content/browser/media/capture/content_capture_device_browsertest_base.cc
[modify] https://crrev.com/19da6931af266c51af0502016fc3057e5942fac6/content/browser/media/capture/content_capture_device_browsertest_base.h
[modify] https://crrev.com/19da6931af266c51af0502016fc3057e5942fac6/content/browser/media/capture/web_contents_video_capture_device.cc
[modify] https://crrev.com/19da6931af266c51af0502016fc3057e5942fac6/content/browser/media/capture/web_contents_video_capture_device_browsertest.cc

Comment 2 by m...@chromium.org, Dec 20

Status: Fixed (was: Started)
►

Sign in to add a comment