Reduce tablet/laptop transition jank by only doing the necessary animations |
|
Issue descriptionChrome Version: 73.0.3641.0 OS: Chrome What steps will reproduce the problem? (1) Open several browser windows, app windows, ARC windows (2) Flip the device back and forth to switch between laptop mode and tablet mode What is the expected result? The transition should be smooth What happens instead? The transition looks a bit janky, especially when there are many windows opened at the time I think we probably can do the same thing as what we did for entering/exit overview: do not do the bounds change animation for all windows, but only do the bounds change animation for a small set of windows, i.e., up to the first window in the MRU list that can be maximized/fullscreened. In this case, in most cases, we only need to do the bounds change animation for the top window during enter/exit tablet mode. And the other windows are just put right in their final position after the top window's bounds animation ends (if it's entering tablet mode), or before the top window's bounds animation (if it's exiting tablet mode). What do you think, Ben, Omri, Oshima? Do you think it's reasonable? Assign to Min first as she already started some investigation on applying window occlusion during transition to reduce jank.
,
Dec 19
Yes, we probably have to try it out on device to see how much it can improve the smoothness. > "We might need to simplify it to just the MRU app." Yes, I agree it's simpler. And think more about it, I feel it should work, since when entering tablet mode, we always place a black backdrop background behind the topmost window. And when exiting tablet mode, we remove the backdrop. Current we don't have any animation to show/hide the backdrop, but we can have some to reduce the possible weird looking animation.
,
Dec 20
There are several scenarios we need to think about. 1) In Home launcher Since no windows are visible in this state, how about fade out home launcher, and just fade in windows w/o bounds/transform animation? 2) One fullscreen app Animate only fullscreen one would be sufficient, like overview exit? 3) In Splitview 3.1) Two windows. Bounds animation for two windows, like 2) above. 3.2) One window, with overview. Bounds animation for active window, and transform animation for windows in overview? 4) In overview mode Apply exit animation used for desktop?
,
Dec 20
Oshima, thanks for the thorough thought! I think there might be one more case to add into your exiting tablet mode summary: 5) One unresizable app. In this case, the black backdrop shows behind the app. we can just do the fade out animation for the black backdrop without any window bounds animation? For entering tablet mode, since all apps will be maximized upon entering tablet mode, (and overview and launcher will exit if they're open), only animate the top window should be sufficient. If the top window is an unresizable window, then we can do the fade-in animation for the black backdrop, and no window bounds animation will be needed. |
|
►
Sign in to add a comment |
|
Comment 1 by mccanny@chromium.org
, Dec 19