New issue
Advanced search Search tips

Issue 916315 link

Starred by 2 users

Issue metadata

Status: Untriaged
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Closing a tab with an HTTP auth prompt dismisses all matching HTTP auth prompts

Project Member Reported by davidben@chromium.org, Dec 18

Issue description

Chrome Version: 71.0.3578.98 (Official Build) (64-bit)
OS: all

I noticed this while working on issue #908926.

What steps will reproduce the problem?
(1) Open two windows.
(2) Load https://davidben.scripts.mit.edu/auth-test/1 in one window.
(3) Load https://davidben.scripts.mit.edu/auth-test/2 in the other. (different URLs is to work around issue #864572)
(4) Close the first tab

What is the expected result?
The second tab is unchanged.

What happens instead?
The second tab's prompt is dismissed. This also happens if the request is an XHR and the site aborts the request.

This is because the OnRequestCancelled flow still trips NotifyAuthCancelled, which is the code to deduplicate user responses to the auth prompts. But the request getting canceled isn't a user response.
 
Oh huh. Actually it happens before this because closing a tab calls Close() on the dialog, and the default implementation calls Cancel().

Though the XHR case is because of the OnRequestCancelled flow.
Yeah, there needs to be a "cancelled without prejudice" option.

Sign in to add a comment