New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916309 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: 2018-12-19
OS: Android
Pri: 1
Type: Bug



Sign in to add a comment

Make Duet IPH duration longer

Project Member Reported by amaralp@chromium.org, Dec 18

Issue description

Chrome Version: M72
OS: Android

The Duet IPH feature highlight times out at 6 seconds. This is too short to read the IPH.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/801a08e5ea506ef84a701260856ad34e5c50065a

commit 801a08e5ea506ef84a701260856ad34e5c50065a
Author: Pedro Amaral <amaralp@chromium.org>
Date: Wed Dec 19 01:18:05 2018

Make Duet IPH 10 seconds instead of 6

Bug:  916309 
Change-Id: Idc888ec45a4dec4eb160884946fa33682f1a214c
Reviewed-on: https://chromium-review.googlesource.com/c/1383357
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617703}
[modify] https://crrev.com/801a08e5ea506ef84a701260856ad34e5c50065a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarMediator.java

Labels: Merge-Request-72
Requesting merge. This is a very safe change as all it does is change the IPH duration from 6 to 10 seconds. Also the change will only happen to the bottom toolbar experiment which is behind a flag.
Project Member

Comment 3 by sheriffbot@chromium.org, Dec 19

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
NextAction: 2018-12-19
Pls update bug with canary result tomorrow. 
The NextAction date has arrived: 2018-12-19
How is the change looking in canary?Is it safe to merge now?
Everything looks good in Canary. Safe to merge
Labels: -Merge-Review-72 Merge-Approved-72
Approving merge to M72 branch 3626 based on comment #7. Please merge ASAP, Thank you.
Project Member

Comment 9 by bugdroid1@chromium.org, Dec 19

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df

commit fcb1d6602aa5d44ff4cc70775e48fcd13e4210df
Author: Pedro Amaral <amaralp@chromium.org>
Date: Wed Dec 19 19:51:05 2018

Make Duet IPH 10 seconds instead of 6

Bug:  916309 
Change-Id: Idc888ec45a4dec4eb160884946fa33682f1a214c
Reviewed-on: https://chromium-review.googlesource.com/c/1383357
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617703}(cherry picked from commit 801a08e5ea506ef84a701260856ad34e5c50065a)
Reviewed-on: https://chromium-review.googlesource.com/c/1384936
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#468}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarMediator.java

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df

Commit: fcb1d6602aa5d44ff4cc70775e48fcd13e4210df
Author: amaralp@chromium.org
Commiter: amaralp@chromium.org
Date: 2018-12-19 19:51:05 +0000 UTC

Make Duet IPH 10 seconds instead of 6

Bug:  916309 
Change-Id: Idc888ec45a4dec4eb160884946fa33682f1a214c
Reviewed-on: https://chromium-review.googlesource.com/c/1383357
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617703}(cherry picked from commit 801a08e5ea506ef84a701260856ad34e5c50065a)
Reviewed-on: https://chromium-review.googlesource.com/c/1384936
Reviewed-by: Pedro Amaral <amaralp@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#468}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
Verified with M73 -73.0.3659.0/HTC10/8.0. Now Duet duration time is increased to 10 seconds
Status: Fixed (was: Started)
Re-tested same with M72-ChromeBeta-72.0.3626.53 build and not displayed IPH help text,when first time the app is started.
Enabled below flags
Chrome Duet
In-Product Help Demo Mode -Enabled IPH_ChromeDuet

Sign in to add a comment