Issue metadata
Sign in to add a comment
|
Make Duet IPH duration longer |
||||||||||||||||||||||
Issue descriptionChrome Version: M72 OS: Android The Duet IPH feature highlight times out at 6 seconds. This is too short to read the IPH.
,
Dec 19
Requesting merge. This is a very safe change as all it does is change the IPH duration from 6 to 10 seconds. Also the change will only happen to the bottom toolbar experiment which is behind a flag.
,
Dec 19
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 19
Pls update bug with canary result tomorrow.
,
Dec 19
The NextAction date has arrived: 2018-12-19
,
Dec 19
How is the change looking in canary?Is it safe to merge now?
,
Dec 19
Everything looks good in Canary. Safe to merge
,
Dec 19
Approving merge to M72 branch 3626 based on comment #7. Please merge ASAP, Thank you.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df commit fcb1d6602aa5d44ff4cc70775e48fcd13e4210df Author: Pedro Amaral <amaralp@chromium.org> Date: Wed Dec 19 19:51:05 2018 Make Duet IPH 10 seconds instead of 6 Bug: 916309 Change-Id: Idc888ec45a4dec4eb160884946fa33682f1a214c Reviewed-on: https://chromium-review.googlesource.com/c/1383357 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617703}(cherry picked from commit 801a08e5ea506ef84a701260856ad34e5c50065a) Reviewed-on: https://chromium-review.googlesource.com/c/1384936 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#468} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df/chrome/android/java/src/org/chromium/chrome/browser/toolbar/bottom/BrowsingModeBottomToolbarMediator.java
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fcb1d6602aa5d44ff4cc70775e48fcd13e4210df Commit: fcb1d6602aa5d44ff4cc70775e48fcd13e4210df Author: amaralp@chromium.org Commiter: amaralp@chromium.org Date: 2018-12-19 19:51:05 +0000 UTC Make Duet IPH 10 seconds instead of 6 Bug: 916309 Change-Id: Idc888ec45a4dec4eb160884946fa33682f1a214c Reviewed-on: https://chromium-review.googlesource.com/c/1383357 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Pedro Amaral <amaralp@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617703}(cherry picked from commit 801a08e5ea506ef84a701260856ad34e5c50065a) Reviewed-on: https://chromium-review.googlesource.com/c/1384936 Reviewed-by: Pedro Amaral <amaralp@chromium.org> Cr-Commit-Position: refs/branch-heads/3626@{#468} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Jan 2
Verified with M73 -73.0.3659.0/HTC10/8.0. Now Duet duration time is increased to 10 seconds
,
Jan 3
,
Jan 9
Re-tested same with M72-ChromeBeta-72.0.3626.53 build and not displayed IPH help text,when first time the app is started. Enabled below flags Chrome Duet In-Product Help Demo Mode -Enabled IPH_ChromeDuet |
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by bugdroid1@chromium.org
, Dec 19