New issue
Advanced search Search tips

Issue 916294 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

WebUI: Update third_party mocha to a more recent version.

Project Member Reported by dpa...@chromium.org, Dec 18

Issue description

Currently third_party/mocha is using version 2.5.3. Latest mocha version according to [1] is 5.2.0.

While there is no specific feature available in the newer versions that I have in mind, we are falling quite a bit behind.

@michaelpg: You are currently listed as an OWNER at [1], which is why I assigned this to you. Let me know if you have no cycles to look into this.

Also, do you have any thoughts about removing third_party/mocha directory completely and using [3] to fetch mocha? This might make updating easier in the future (similarly to how we updated other NPM dependencies).

[1] https://github.com/mochajs/mocha/blob/master/CHANGELOG.md
[2] https://cs.chromium.org/chromium/src/third_party/mocha/OWNERS
[3] https://cs.chromium.org/chromium/src/third_party/node/package.json
 
Labels: M-74
Status: Assigned (was: Untriaged)
I can take a look in M-74 time frame.

Node modules in third_party/node are executed at build time, but aren't read or loaded directly by the built binaries (chrome or tests), right? Is there any reason we should avoid doing that with mocha?
third_party/node/node_modules are not included in the build. They are only used by various python scripts during build/PRESUBMIT. See https://cs.chromium.org/chromium/src/third_party/node/node_modules.py?l=16,21,25,29,33

Sign in to add a comment