Issue 916287 link

Starred by 2 users

Issue metadata

Status:	Fixed
Owner:	bajones@chromium.org
Closed:	Jan 7
Components:	Internals>XR
EstimatedDays:	----
NextAction:	----
OS:	Android , Windows
Pri:	3
Type:	Bug
Proj-XR Target-73
Proj-VR

Update WebGL/WebXR compatibility calls

Project Member Reported by bajones@chromium.org, Dec 18

Issue description

The latest WebXR spec changes have removed the necessity to specify an XRDevice when setting WebGL context compatibility.

Project Member

Comment 1 by bugdroid1@chromium.org, Jan 4

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267

commit 151f2606ad848e39a8e0d4ac88a0a0b5a32f5267
Author: Brandon Jones <bajones@chromium.org>
Date: Fri Jan 04 23:57:37 2019

Removed XRDevice from WebGL context compatibility

This is the first step to removing XRDevice entirely.

Bug:  916287 
Change-Id: Ie5f86738632636927a822c6ccbecba3202446d41
Reviewed-on: https://chromium-review.googlesource.com/c/1383391
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Reviewed-by: Miguel Casas <mcasas@chromium.org>
Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620114}
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/chrome/test/data/xr/e2e_test_files/resources/webxr_boilerplate.js
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/core/html/canvas/canvas_context_creation_attributes_core.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/core/html/canvas/canvas_context_creation_attributes_core.h
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/core/html/canvas/canvas_rendering_context.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/canvas/htmlcanvas/canvas_context_creation_attributes_helpers.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/canvas/htmlcanvas/canvas_context_creation_attributes_module.idl
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/webgl/webgl_context_attribute_helpers.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/webgl/webgl_context_attributes.idl
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.h
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/webgl/webgl_rendering_context_base.idl
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/renderer/modules/xr/xr_webgl_layer.cc
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/external/WPT_BASE_MANIFEST_5.json
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/external/wpt/webxr/idlharness.https.window-expected.txt
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/external/wpt/webxr/resources/webxr_util.js
[delete] https://crrev.com/e92cd32221129be3b20ec8d05ac9ff41f6e6856c/third_party/blink/web_tests/external/wpt/webxr/webGLCanvasContext_create_with_xrdevice.https.html
[add] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/external/wpt/webxr/webGLCanvasContext_create_xrcompatible.https.html
[add] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/external/wpt/webxr/webGLCanvasContext_makecompatible_contextlost.https.html
[delete] https://crrev.com/e92cd32221129be3b20ec8d05ac9ff41f6e6856c/third_party/blink/web_tests/external/wpt/webxr/webGLCanvasContext_setdevice_contextlost.https.html
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/http/tests/serviceworker/webexposed/global-interface-listing-service-worker-expected.txt
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/webexposed/global-interface-listing-dedicated-worker-expected.txt
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/webexposed/global-interface-listing-expected.txt
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/webexposed/global-interface-listing-shared-worker-expected.txt
[modify] https://crrev.com/151f2606ad848e39a8e0d4ac88a0a0b5a32f5267/third_party/blink/web_tests/xr/resources/xr-test-utils.js