New issue
Advanced search Search tips

Issue 916274 link

Starred by 2 users
Status: Fixed
Owner: ----
Closed: Jan 8
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

HistoryTabHelper uses old referrer when filtering navigations from content suggestions

Project Member Reported by pav...@chromium.org, Dec 18 
HistoryTabHelper maintains local constant with referrer string that it uses to prevent clicks on suggested articles from appearing in "Most Visited" tiles: [1]. Referrer string is controlled by Finch config: [2].

HistoryTabHelper should call GetContentSuggestionsReferrerURL() to obtain referrer. It should also check for AUTO_BOOKMARK page transition.


[1]: https://cs.chromium.org/chromium/src/chrome/browser/history/history_tab_helper.cc?q=chrome-content-suggestions&sq=package:chromium&dr=C&l=71
[2]: crrev.com/c/1185857
Project Member

Comment 1 by bugdroid1@chromium.org, Jan 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c94f00e96b0781a6bfec51bb44f35c028717c91f

commit c94f00e96b0781a6bfec51bb44f35c028717c91f
Author: Pavel Yatsuk <pavely@google.com>
Date: Tue Jan 08 19:54:57 2019

Get HistoryTabHelper to use GetContentSuggestionsReferrerURL instead of local constant.

Referrer that content suggestions navigations get annotated with is now
controlled by Finch experiment (crrev.com/c/1185857).
GetContentSuggestionsReferrerURL() should be used to retrieve its value.

BUG= 916274 

Change-Id: Ia64f1119b8952e2a8500d9e4a7d6a29fdef4c5f2
Reviewed-on: https://chromium-review.googlesource.com/c/1384937
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Commit-Queue: Pavel Yatsuk <pavely@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620844}
[modify] https://crrev.com/c94f00e96b0781a6bfec51bb44f35c028717c91f/chrome/browser/history/history_tab_helper.cc
[modify] https://crrev.com/c94f00e96b0781a6bfec51bb44f35c028717c91f/ios/chrome/browser/history/history_tab_helper.mm

Comment 2 by pav...@chromium.org, Jan 8

Status: Fixed (was: Available)
►

Sign in to add a comment