The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198

commit 0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Wed Dec 19 13:48:29 2018

Refactor variations seed fetch logic to handle errors better.

The previous logic did not handle fetch interrupts correctly,
which resulted in crashes. The crashes were introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/1097213/

Which landed all the way in M69! But no one filed a bug about
the crashes until recently. :(

Adds a test for this, which also required modifying
TestURLLoaderFactory to support preserving the response code when
there's an error, via an additional flag.

Also fixes inverted logic for the histograms
Variations.SeedFetchResponseOrErrorCode and
Variations.SeedFetchResponseOrErrorCode.HTTP which was broken by:
https://chromium-review.googlesource.com/c/chromium/src/+/1335666

Includes test changes for the above as well.

Bug: 915640,  916245 
Change-Id: I8920cd7fc004efd355054a999791c00f3d480525
Reviewed-on: https://chromium-review.googlesource.com/c/1382696
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617818}
[modify] https://crrev.com/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198/components/variations/service/variations_service.cc
[modify] https://crrev.com/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/0ae9fa17dc41f7463a4f284b6d3a3ccb9785b198/services/network/test/test_url_loader_factory.h

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/d2f88be553c0d9a500dab2118016e988ca914532

Commit: d2f88be553c0d9a500dab2118016e988ca914532
Author: asvitkine@chromium.org
Commiter: govind@chromium.org
Date: 2018-12-21 18:50:38 +0000 UTC

Refactor variations seed fetch logic to handle errors better.

[M72 Merge]

The previous logic did not handle fetch interrupts correctly,
which resulted in crashes. The crashes were introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/1097213/

Which landed all the way in M69! But no one filed a bug about
the crashes until recently. :(

Adds a test for this, which also required modifying
TestURLLoaderFactory to support preserving the response code when
there's an error, via an additional flag.

Also fixes inverted logic for the histograms
Variations.SeedFetchResponseOrErrorCode and
Variations.SeedFetchResponseOrErrorCode.HTTP which was broken by:
https://chromium-review.googlesource.com/c/chromium/src/+/1335666

Includes test changes for the above as well.

TBR=asvitkine@chromium.org

Bug: 915640,  916245 
Reviewed-on: https://chromium-review.googlesource.com/c/1382696
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617818}
Change-Id: I52bac44240d2ecf2666bfbc5316c5da87c910625
Reviewed-on: https://chromium-review.googlesource.com/c/1388157
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#499}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d2f88be553c0d9a500dab2118016e988ca914532

commit d2f88be553c0d9a500dab2118016e988ca914532
Author: Alexei Svitkine <asvitkine@chromium.org>
Date: Fri Dec 21 18:50:38 2018

Refactor variations seed fetch logic to handle errors better.

[M72 Merge]

The previous logic did not handle fetch interrupts correctly,
which resulted in crashes. The crashes were introduced by:
https://chromium-review.googlesource.com/c/chromium/src/+/1097213/

Which landed all the way in M69! But no one filed a bug about
the crashes until recently. :(

Adds a test for this, which also required modifying
TestURLLoaderFactory to support preserving the response code when
there's an error, via an additional flag.

Also fixes inverted logic for the histograms
Variations.SeedFetchResponseOrErrorCode and
Variations.SeedFetchResponseOrErrorCode.HTTP which was broken by:
https://chromium-review.googlesource.com/c/chromium/src/+/1335666

Includes test changes for the above as well.

TBR=asvitkine@chromium.org

Bug: 915640,  916245 
Reviewed-on: https://chromium-review.googlesource.com/c/1382696
Reviewed-by: Carlos IL <carlosil@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#617818}
Change-Id: I52bac44240d2ecf2666bfbc5316c5da87c910625
Reviewed-on: https://chromium-review.googlesource.com/c/1388157
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#499}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/d2f88be553c0d9a500dab2118016e988ca914532/components/variations/service/variations_service.cc
[modify] https://crrev.com/d2f88be553c0d9a500dab2118016e988ca914532/components/variations/service/variations_service_unittest.cc
[modify] https://crrev.com/d2f88be553c0d9a500dab2118016e988ca914532/services/network/public/cpp/simple_url_loader.h
[modify] https://crrev.com/d2f88be553c0d9a500dab2118016e988ca914532/services/network/test/test_url_loader_factory.cc
[modify] https://crrev.com/d2f88be553c0d9a500dab2118016e988ca914532/services/network/test/test_url_loader_factory.h