Issue metadata
Sign in to add a comment
|
Regression: When the window is very small, the Omnibox shouldn't be draggable |
||||||||||||||||||||
Issue descriptionChrome Version: Canary 73.0.3644.0 OS: macOS 10.14.2 What steps will reproduce the problem? (1) Install some extensions, so that their icons appear on the Toolbar (2) Shrink the window to its smallest size (3) Play with the resizer of the Omnibox What is the expected result? Resizing should not be possible in its smallest size, because it ends in a flicker. What happens instead? The Omnibox snaps back and it flickers. When you enlarge the window again, the extension icon are no longer on the Toolbar. They are hidden in the Menu. I think this is caused after fixing issue 842239 . Please find attached a screencast. dfried@: Can you please take a look. Thanks :)
,
Dec 18
I'll take a look at this and see if I can find out why it's happening.
,
Dec 18
Great - Thank you very much :)
,
Dec 18
,
Dec 18
(FYI: Regression range: https://chromium.googlesource.com/chromium/src/+log/39448a3db140a19d21a1bbc7ce2739fefad914b5..75bb478ac3649caf7d93623b32974a0d05f9066c Probably also caused by your CL https://chromium.googlesource.com/chromium/src/+/c77b0235fe8e67c60160fadcf5ce4c40b0563343 )
,
Dec 18
Handing off to pbos@ as it's part of a larger change he's pursuing.
,
Dec 19
When you shrink the window to very small and enlarges it again, the Omnibox overlaps the extension icons during and snaps back during resizing. Not sure, but probably related. If not, please let me know, so that I can open a new report. A screencast is attached. Thanks.
,
Dec 19
This is all related to the same issue in the codebase. There is some technical debt around the browser actions toolbar element that Peter is going to help clean up.
,
Dec 19
Okay, thank you for your feedback :)
,
Jan 4
Hey pbos@: FYI, if a fix is currently in work - I also noticed, that when the window is very small and you open chrome://settings, the profile button and the menu button disappear from the toolbar. This is probably because the chrome://settings page is showing the "Chrome" chip in the Omnibox. This is probably caused by the same CL mentioned in c#5. I can check it further, if you want. Here is a screencast of the issue. Thanks :)
,
Jan 4
I would assume that going to chrome://settings actually increases the minimum omnibox size, which increases the minimum toolbar size, which now gets pushed outside the window (that does not resize). Could you check whether this could happen before?
,
Jan 4
Gotcha. Thank you, those really help. :) |
|||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||
Comment 1 by dfried@chromium.org
, Dec 18Status: Assigned (was: Untriaged)