Regression: Cast Icon reappears on the Toolbar |
||||||
Issue descriptionChrome Version: Canary Version 73.0.3644.0 OS: macOS 10.14.2 What steps will reproduce the problem? (1) Open a window What is the expected result? No Cast Icon. What happens instead? Cast Icon appears. When I click on it, it disappears. But when I open a new window, it reappears again. This is a bad user experience :( Thanks.
,
Dec 18
,
Dec 18
https://chromium.googlesource.com/chromium/src/+/c77b0235fe8e67c60160fadcf5ce4c40b0563343 The issue seems to have been introduced in this CL; reverting it locally fixed the bug for me. dfried@ could you take a look?
,
Dec 18
You may need to use --enable-features=ViewsCastDialog to repro.
,
Dec 18
Taking this one.
,
Dec 18
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c87ad633b6c4f9aac5834ceb8f3f893534231673 commit c87ad633b6c4f9aac5834ceb8f3f893534231673 Author: Dana Fried <dfried@chromium.org> Date: Wed Dec 19 21:52:45 2018 Flex layout now picks up initial visibility of child views. Should be at least progress towards (if not a fix for) the Cast bug, as well as a prerequisite for issue #916092 . Bug: 916201 Change-Id: I6f89e3eb2245a536ce504603050a9467c15a4cee Reviewed-on: https://chromium-review.googlesource.com/c/1383532 Reviewed-by: Scott Violet <sky@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#617968} [modify] https://crrev.com/c87ad633b6c4f9aac5834ceb8f3f893534231673/ui/views/layout/flex_layout.cc [modify] https://crrev.com/c87ad633b6c4f9aac5834ceb8f3f893534231673/ui/views/layout/flex_layout_unittest.cc
,
Dec 19
Need verification, but this change should have fixed the issue.
,
Dec 19
Thanks, will check in next Canary. |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by meh...@chromium.org
, Dec 18