New issue
Advanced search Search tips

Issue 916199 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac , Fuchsia
Pri: 2
Type: Bug

Blocking:
issue 890118



Sign in to add a comment

Favicons on the password page should not disappear

Project Member Reported by vasi...@chromium.org, Dec 18

Issue description

The favicons are disappearing over time. It creates a bad experience on the chrome://settings/passwords page as we launch the favicons there.

We should pin the password favicons as we do it for the bookmarks.
 
Sorry I'm not clear what the issue is here?
Favicons are disappearing for sites that haven’t been visited for a long time. We should switch to another service (like the one used by bookmarks) so that the favicons are pinned in the cache.
Missing Favicons.png
254 KB View Download
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/7216805dea11123adb68d66f41eceb0305ce6743

commit 7216805dea11123adb68d66f41eceb0305ce6743
Author: vasilii <vasilii@chromium.org>
Date: Fri Jan 11 08:32:53 2019

Rename IsBookmarked and GetBookmarks of HistoryBackendClient to be generic.

The password manager UI uses the icons as well and they are to be pinned.

Bug: 916199
Change-Id: Ic2e1472d2373d3ab53cbf8aa6a93b15c9cd7a3b7
Reviewed-on: https://chromium-review.googlesource.com/c/1386853
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621948}
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/chrome/browser/history/android/android_provider_backend.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/chrome/browser/history/chrome_history_backend_client.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/chrome/browser/history/chrome_history_backend_client.h
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/components/history/core/browser/expire_history_backend.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/components/history/core/browser/expire_history_backend.h
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/components/history/core/browser/history_backend.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/components/history/core/browser/history_backend_client.h
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/components/history/core/test/history_client_fake_bookmarks.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/ios/chrome/browser/history/history_backend_client_impl.cc
[modify] https://crrev.com/7216805dea11123adb68d66f41eceb0305ce6743/ios/chrome/browser/history/history_backend_client_impl.h

Sign in to add a comment