Browser crashes when using Local NTP, a doodle is present, and passing a --google-base-url |
|||
Issue descriptionWhen starting a recent local (or Canary?) build and passing --google-base-url, enabling use-google-local-ntp, and a Doodle is present the browser crashes :( Received signal 6 #0 0x7f24d425ef58 base::debug::StackTrace::StackTrace() #1 0x7f24d40aabaa base::debug::StackTrace::StackTrace() #2 0x7f24d425e9fa base::debug::(anonymous namespace)::StackDumpSignalHandler() #3 0x7f24b0e4b0c0 <unknown> #4 0x7f24acbe8fcf gsignal #5 0x7f24acbea3fa abort #6 0x7f24b137f0a2 std::__terminate() #7 0x7f24b137e32a __cxxabiv1::failed_throw() #8 0x7f24b137e27f __cxa_throw #9 0x7f24b1371e0b std::__1::__throw_out_of_range() #10 0x7f24b1371db8 std::__1::__basic_string_common<>::__throw_out_of_range() #11 0x7f24b1373b2d std::__1::basic_string<>::replace() #12 0x55b761ecc9f1 std::__1::basic_string<>::replace() #13 0x55b763165a1c (anonymous namespace)::ConvertLogoMetadataToDict() #14 0x55b763168711 LocalNtpSource::DesktopLogoObserver::OnLogoAvailable() #15 0x55b7631682fd LocalNtpSource::DesktopLogoObserver::OnFreshLogoAvailable() From this bit of the stack trace it looks like some of the recent refactoring from https://chromium-review.googlesource.com/c/chromium/src/+/1377969 broke something.
,
Dec 18
Turns out I broke it with https://crrev.com/c/1373886
,
Dec 18
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/17b0f10ed700f07d8c5cdb54a3e5a8f3e089acde commit 17b0f10ed700f07d8c5cdb54a3e5a8f3e089acde Author: Kyle Milka <kmilka@chromium.org> Date: Tue Dec 18 21:35:21 2018 [NTP] Fix crash when a doodle is present When a non-interactive doodle is present and a google-base-url is specified on the command line the attempt to modify the fullpage url would fail. Only modify it if 'https://www.google.com/' is present (it's non-empty). Bug: 916185 Change-Id: I12d10d32aab36cf29d2ddfeaf7f26494da8c4de9 Reviewed-on: https://chromium-review.googlesource.com/c/1382898 Reviewed-by: Kristi Park <kristipark@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#617631} [modify] https://crrev.com/17b0f10ed700f07d8c5cdb54a3e5a8f3e089acde/chrome/browser/search/local_ntp_source.cc
,
Dec 18
,
Jan 8
The NextAction date has arrived: 2019-01-08 |
|||
►
Sign in to add a comment |
|||
Comment 1 by kmilka@chromium.org
, Dec 18