New issue
Advanced search Search tips

Issue 916183 link

Starred by 1 user
Status: Fixed
Owner:
sky@chromium.org
Closed: Dec 19
Cc:
jamescook@chromium.org
mustash-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 916178



Sign in to add a comment

Replace SingleProcessMash filter files with early outs

Project Member Reported by sky@chromium.org, Dec 18 
As we get close to making SingleProcessMash on by default, we need to remove the filter files and instead have early outs. Having early outs means the test passes with SPM disabled or enabled. The tests should be converted to something like:

TEST(...) {
  if (features::IsSingleProcessMash())
    return;  // TODO...
}

Ideally this is in the TEST body, but there may need to be early outs in SetUp/TearDown() as well.

These files need to be removed:

testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter
testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
testing/buildbot/filters/chromeos.single_process_mash.unit_tests.filter

Comment 1 by sky@chromium.org, Dec 18

Owner: sky@chromium.org
Status: Started (was: Untriaged)
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/6b239f5859c092965082437285366eb2927157f4

commit 6b239f5859c092965082437285366eb2927157f4
Author: Scott Violet <sky@chromium.org>
Date: Tue Dec 18 23:21:34 2018

chromeos: removes single_process_mash.browser_tests.filter file

And instead adds early outs. This way the tree will be green when we switch
SingleProcessMash on by default.

BUG= 916183 
TEST=test only changes

Change-Id: Ia726b2a78cb6628bc8574a7cc06e4cea9c101693
Reviewed-on: https://chromium-review.googlesource.com/c/1382909
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617667}
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/chromeos/login/kiosk_browsertest.cc
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/extensions/api/web_request/web_request_apitest.cc
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/prerender/prerender_browsertest.cc
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/resources/chromeos/chromevox/cvox2/background/panel_test.extjs
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/ui/ash/keyboard/keyboard_end_to_end_browsertest.cc
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/chrome/browser/ui/views/frame/browser_non_client_frame_view_ash_browsertest.cc
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/ad77c3f2bdef9f0c9a10e7b36e2ceaae3090d758/testing/buildbot/filters/chromeos.single_process_mash.browser_tests.filter
[modify] https://crrev.com/6b239f5859c092965082437285366eb2927157f4/testing/buildbot/test_suites.pyl
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3390498574ccc92b452a477e3c67b2739865f496

commit 3390498574ccc92b452a477e3c67b2739865f496
Author: Scott Violet <sky@chromium.org>
Date: Wed Dec 19 03:16:49 2018

chromeos: removes single_process_mash.content_browser_tests.filter file

And instead adds early outs. This way the tree will be green when we switch
SingleProcessMash on by default.

BUG= 916183 
TEST=test only changes

Change-Id: I50409797502b36aa54e952683b76d78cddb1e89c
Reviewed-on: https://chromium-review.googlesource.com/c/1383144
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617717}
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/content/browser/devtools/protocol/devtools_protocol_browsertest.cc
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/content/browser/media/capture/aura_window_video_capture_device_browsertest.cc
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/5c6c67597ad28aca94ab863e05f436f5d32ac556/testing/buildbot/filters/chromeos.single_process_mash.content_browsertests.filter
[modify] https://crrev.com/3390498574ccc92b452a477e3c67b2739865f496/testing/buildbot/test_suites.pyl
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b373e9317d0985abbbdca59877ae8ad80919abef

commit b373e9317d0985abbbdca59877ae8ad80919abef
Author: Scott Violet <sky@chromium.org>
Date: Wed Dec 19 06:58:03 2018

chromeos: removes single_process_mash.interactive_ui_tests.filter file

And instead adds early outs. This way the tree will be green when we switch
SingleProcessMash on by default.

BUG= 916183 ,897879,916379
TEST=test only changes

Change-Id: I0e32837a216e02611ceb2b1454c31cf2c4defb4e
Reviewed-on: https://chromium-review.googlesource.com/c/1383124
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: Jun Mukai <mukai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617746}
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/chrome/browser/browser_keyevents_browsertest.cc
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/chrome/browser/extensions/extension_fullscreen_apitest.cc
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/94cbc94bffae9985b93e9b8381907726faf5efb7/testing/buildbot/filters/chromeos.single_process_mash.interactive_ui_tests.filter
[modify] https://crrev.com/b373e9317d0985abbbdca59877ae8ad80919abef/testing/buildbot/test_suites.pyl
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ea05a096e6d36f5f099c1724dbc4e94be311abbe

commit ea05a096e6d36f5f099c1724dbc4e94be311abbe
Author: Scott Violet <sky@chromium.org>
Date: Wed Dec 19 17:53:22 2018

chromeos: removes single_process_mash.unit_tests.filter file

And instead adds early outs. This way the tree will be green when we switch
SingleProcessMash on by default.

BUG= 916183 
TEST=test only changes

Change-Id: I7406c781491fb312ba8d8a361e3d045af4ec430d
Reviewed-on: https://chromium-review.googlesource.com/c/1383127
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617872}
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/chrome/browser/chromeos/arc/input_method_manager/arc_input_method_manager_service_unittest.cc
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/chrome/browser/ui/browser_finder_chromeos_unittest.cc
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/chrome/browser/ui/views/omnibox/omnibox_view_views_unittest.cc
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/chrome/test/BUILD.gn
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/testing/buildbot/chromium.chromiumos.json
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/testing/buildbot/chromium.memory.json
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/testing/buildbot/filters/BUILD.gn
[delete] https://crrev.com/7ad6601cebdb0f70493ffc0cfdc8d993836c3a91/testing/buildbot/filters/chromeos.single_process_mash.unit_tests.filter
[modify] https://crrev.com/ea05a096e6d36f5f099c1724dbc4e94be311abbe/testing/buildbot/test_suites.pyl

Comment 6 by sky@chromium.org, Dec 19

Status: Fixed (was: Started)
►

Sign in to add a comment