New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 916182 link

Starred by 3 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 3
Type: Bug

Blocking:
issue 901429



Sign in to add a comment

[Self share] Create context menu item on desktop for self share

Project Member Reported by ew...@chromium.org, Dec 18

Issue description

Tracking bug to add a menu item to the right-click context menu for tabs + content area as well as three-dot menu for sending tab to self.
 
Cc: hansberry@chromium.org
Components: -UI UI>Browser>Sharing
Project Member

Comment 3 by bugdroid1@chromium.org, Dec 21

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/788aac25e3fea9635b84d36c9f82387b4c54be38

commit 788aac25e3fea9635b84d36c9f82387b4c54be38
Author: Tina Wang <tinazwang@chromium.org>
Date: Fri Dec 21 20:25:46 2018

Initial self share feature in browser

Adding "Send to my devices" feature to:
  tab context menu
  page menu
  content area right click menu.

All features are under "Send tab to self" flag.

Bug: 916182
Change-Id: Ic292f622da836f76e6c7714b79690c6de6489f51
Reviewed-on: https://chromium-review.googlesource.com/c/1376652
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618580}
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/app/chrome_command_ids.h
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/app/generated_resources.grd
[add] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/app/generated_resources_grd/IDS_CONTENT_CONTEXT_SEND_TO_MY_DEVICES.png.sha1
[add] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/app/generated_resources_grd/IDS_SEND_TO_MY_DEVICES.png.sha1
[add] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/app/generated_resources_grd/IDS_TAB_CXMENU_SEND_TO_MY_DEVICES.png.sha1
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/renderer_context_menu/render_view_context_menu.cc
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/browser_command_controller.cc
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/browser_commands.h
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/tabs/tab_menu_model.cc
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/tabs/tab_strip_model.cc
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/tabs/tab_strip_model.h
[modify] https://crrev.com/788aac25e3fea9635b84d36c9f82387b4c54be38/chrome/browser/ui/toolbar/app_menu_model.cc

Project Member

Comment 4 by bugdroid1@chromium.org, Jan 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5bd9155c2aad519698821bd505a4987d37d6d770

commit 5bd9155c2aad519698821bd505a4987d37d6d770
Author: Tina Wang <tinazwang@chromium.org>
Date: Mon Jan 07 18:54:28 2019

Add lacking part of content context menu option

 - source file variable name correction
 - add case to ExecuteCommand function

Bug: 916182
Change-Id: I1fc14b66af19a277ec6ed391fb1d5b67d6b0f9b7
Reviewed-on: https://chromium-review.googlesource.com/c/1391744
Reviewed-by: Lei Zhang <thestig@chromium.org>
Commit-Queue: Tina Wang <tinazwang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#620399}
[modify] https://crrev.com/5bd9155c2aad519698821bd505a4987d37d6d770/chrome/browser/renderer_context_menu/render_view_context_menu.cc

Sign in to add a comment