extensions_browsertests fail with SingleProcessMash on |
||||
Issue descriptionThey all seem to fail creating multiple UICursorFactoryOzones: #0 0x55dc9e453f5f base::debug::StackTrace::StackTrace() #1 0x55dc9e3c16bb logging::LogMessage::~LogMessage() #2 0x55dc9f415989 ui::CursorFactoryOzone::GetInstance() #3 0x55dc9ef53b51 ui::CursorLoader::Create() #4 0x55dc9ef578ac ui::ImageCursors::SetDisplay() #5 0x55dc9e2efb51 extensions::(anonymous namespace)::ShellNativeCursorManager::SetDisplay() #6 0x55dc9ff6f112 wm::CursorManager::SetDisplay() #7 0x55dc9e2ef6be extensions::ShellDesktopControllerAura::InitWindowManager() #8 0x55dc9e2ee28f extensions::ShellDesktopControllerAura::ShellDesktopControllerAura() #9 0x55dc9e2df392 extensions::DefaultShellBrowserMainDelegate::CreateDesktopController() #10 0x55dc9e2e2ee6 extensions::ShellBrowserMainParts::PreMainMessageLoopRun() #11 0x55dc9ccaadf2 content::BrowserMainLoop::PreMainMessageLoopRun() #12 0x55dc9d162c85 content::StartupTaskRunner::RunAllTasksNow() #13 0x55dc9cca9ad5 content::BrowserMainLoop::CreateStartupTasks() #14 0x55dc9ccacf29 content::BrowserMainRunnerImpl::Initialize() #15 0x55dc9cca7afb content::BrowserMain() #16 0x55dc9e28bfa1 content::ContentMainRunnerImpl::RunServiceManager() #17 0x55dc9e28bbb4 content::ContentMainRunnerImpl::Run() #18 0x55dc9fcbe5c9 service_manager::Main() #19 0x55dc9d4d5924 content::ContentMain() #20 0x55dc9ffbed7c content::BrowserTestBase::SetUp() #21 0x55dc9bbcffd2 extensions::AppShellTest::SetUp() #22 0x55dc9d4c31a0 testing::Test::Run() #23 0x55dc9d4c3c5f testing::TestInfo::Run() #24 0x55dc9d4c4187 testing::TestCase::Run() #25 0x55dc9d4d03c7 testing::internal::UnitTestImpl::RunAllTests() #26 0x55dc9d4cff3d testing::UnitTest::Run() #27 0x55dc9ffcedd1 base::TestSuite::Run() #28 0x55dc9bbd00e7 extensions::AppShellTestLauncherDelegate::RunTestSuite() #29 0x55dc9ffc5c7a content::LaunchTests() #30 0x55dc9bbd0244 main #31 0x7f4636563f45 __libc_start_main #32 0x55dc9bb78daa _start You can see this if you change the default for the SingleProcessMash feature flag to ENABLED_BY_DEFAULT.
,
Dec 18
,
Dec 18
FYI - extensions_browsertests contains some app_shell code, which has some pieces similar to ash. For example, I think there is a RootWindowController equivalent. Those pieces might be to be tweaked to be more similar to ash under SingleProcessMash.
,
Dec 19
Let's disable mash for extensions_browsertests for now.
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/193b7b7b4ec64e24043b24687538e9e23409949c commit 193b7b7b4ec64e24043b24687538e9e23409949c Author: Xiyuan Xia <xiyuan@chromium.org> Date: Thu Dec 20 21:06:36 2018 Disable mash for extensions_browsertests Until test infra code is updated similar to content_browsertests to use Window Service. Bug: 916180 Change-Id: Ic348c81874cae60258ebfe20cd6f4223a2ec7e4a Reviewed-on: https://chromium-review.googlesource.com/c/1385468 Reviewed-by: Michael Giuffrida <michaelpg@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#618321} [modify] https://crrev.com/193b7b7b4ec64e24043b24687538e9e23409949c/extensions/shell/BUILD.gn [modify] https://crrev.com/193b7b7b4ec64e24043b24687538e9e23409949c/extensions/shell/test/shell_test.cc [modify] https://crrev.com/193b7b7b4ec64e24043b24687538e9e23409949c/extensions/shell/test/shell_test.h
,
Dec 20
|
||||
►
Sign in to add a comment |
||||
Comment 1 by sky@chromium.org
, Dec 18