New issue
Advanced search Search tips

Issue 916179 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Dec 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug

Blocking:
issue 916178



Sign in to add a comment

app_shell_unittests fails with SingleProcessMash

Project Member Reported by sky@chromium.org, Dec 18

Issue description

Here's the output:

[ RUN      ] RootWindowControllerTest.AppWindows
[32120:32120:1217/104032.244306:29285323074:FATAL:test_browser_thread_bundle.cc(98)] Check failed: !MainThreadHasPendingTask(). 
#0 0x55b7bb5656bf base::debug::StackTrace::StackTrace()
#1 0x55b7bb4d937b logging::LogMessage::~LogMessage()
#2 0x55b7bb5cb332 content::TestBrowserThreadBundle::~TestBrowserThreadBundle()
#3 0x55b7bb5cb3be content::TestBrowserThreadBundle::~TestBrowserThreadBundle()
#4 0x55b7bb5ce9d8 extensions::ExtensionsTest::~ExtensionsTest()
#5 0x55b7b8f1fc2f extensions::RootWindowControllerTest_Basic_Test::~RootWindowControllerTest_Basic_Test()
#6 0x55b7bb46aced testing::TestInfo::Run()
#7 0x55b7bb46b1b7 testing::TestCase::Run()
#8 0x55b7bb4773f7 testing::internal::UnitTestImpl::RunAllTests()
#9 0x55b7bb476f6d testing::UnitTest::Run()
#10 0x55b7bb5a47d1 base::TestSuite::Run()
#11 0x55b7bb5a639d base::(anonymous namespace)::LaunchUnitTestsInternal()
#12 0x55b7bb5a6201 base::LaunchUnitTests()
#13 0x55b7b8f12f22 main
#14 0x7f39af1daf45 __libc_start_main
#15 0x55b7b8f12d6a _start
 
components_unittests fails with the same error.

[ RUN      ] Regular/PasswordProtectionServiceTest.TestTearDownWithPendingRequests/0
[6063:6063:1217/104039.241404:15051843344:ERROR:test_database_manager.cc(27)] Not implemented reached in virtual bool safe_browsing::TestSafeBrowsingDatabaseManager::CanCheckUrl(const GURL &) const
[6063:6077:1217/104039.250269:15051852210:ERROR:simple_index_file_posix.cc(36)] opendir /b/s/w/itDqgN6a/.org.chromium.Chromium.5BVO6v/Code Cache/js: No such file or directory (2)
[6063:6077:1217/104039.250431:15051852369:ERROR:simple_index_file.cc(603)] Could not reconstruct index from disk
[6063:6063:1217/104039.258575:15051860516:FATAL:test_browser_thread_bundle.cc(98)] Check failed: !MainThreadHasPendingTask().
#0 0x5630fb1e1e4f base::debug::StackTrace::StackTrace()
#1 0x5630fb149a5b logging::LogMessage::~LogMessage()
#2 0x5630fcd74602 content::TestBrowserThreadBundle::~TestBrowserThreadBundle()
#3 0x5630f8c33be5 safe_browsing::PasswordProtectionServiceTest::~PasswordProtectionServiceTest()
#4 0x5630f8c32f1e safe_browsing::PasswordProtectionServiceTest_TestRequestTimedout_Test::~PasswordProtectionServiceTest_TestRequestTimedout_Test()
#5 0x5630f8e3752d testing::TestInfo::Run()
#6 0x5630f8e379f7 testing::TestCase::Run()
#7 0x5630f8e43c37 testing::internal::UnitTestImpl::RunAllTests()
#8 0x5630f8e437ad testing::UnitTest::Run()
#9 0x5630fbec2821 base::TestSuite::Run()
#10 0x5630fbec506d base::(anonymous namespace)::LaunchUnitTestsInternal()
#11 0x5630fbec4ed1 base::LaunchUnitTests()
#12 0x5630f863002d main
#13 0x7fee56e4af45 __libc_start_main
#14 0x5630f700290a _start
Cc: -jamescook@chromium.org
Owner: jamescook@chromium.org
Status: Started (was: Available)
Cc: xiy...@chromium.org est...@chromium.org
Labels: OS-Chrome
I'm seeing a different failure, seems related to Ozone init, similar to  issue 916180 

[ RUN      ] RootWindowControllerTest.AppWindows
[69033:69033:1218/095734.954120:588251804027:FATAL:x11_window_ozone.cc(23)] Check failed: window_manager. 
#0 0x7f66df8ee11f base::debug::StackTrace::StackTrace()
#1 0x7f66df81ba0b logging::LogMessage::~LogMessage()
#2 0x7f66d4347c20 ui::X11WindowOzone::X11WindowOzone()
#3 0x7f66d4346090 ui::(anonymous namespace)::OzonePlatformX11::CreatePlatformWindow()
#4 0x7f66da8ae44f aura::WindowTreeHostPlatform::WindowTreeHostPlatform()
#5 0x7f66da8ae2e4 aura::WindowTreeHost::Create()
#6 0x558361f6c966 extensions::RootWindowController::RootWindowController()
#7 0x558361f55fef extensions::RootWindowControllerTest_AppWindows_Test::TestBody()
#8 0x55836219e091 testing::Test::Run()
#9 0x55836219e91f testing::TestInfo::Run()
#10 0x55836219ee47 testing::TestCase::Run()
#11 0x5583621ab1b7 testing::internal::UnitTestImpl::RunAllTests()
#12 0x5583621aad2d testing::UnitTest::Run()
#13 0x558362284321 base::TestSuite::Run()
#14 0x558362285f8d base::(anonymous namespace)::LaunchUnitTestsInternal()
#15 0x558362285df1 base::LaunchUnitTests()
#16 0x558361f496e2 main
#17 0x7f66d26162b1 __libc_start_main
#18 0x558361f4952a _start

Project Member

Comment 4 by bugdroid1@chromium.org, Dec 19

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ab78ff80ee2ffe91b1aee6ca60618bca532631a6

commit ab78ff80ee2ffe91b1aee6ca60618bca532631a6
Author: James Cook <jamescook@chromium.org>
Date: Wed Dec 19 18:23:21 2018

aura: Disable mash in app_shell_unittests and components_unittests

The code under test won't talk to the window service (mus) in
production, so disable mash feature flags. This configures aura
with aura::Env::Mode::LOCAL, which is what these suites expect.

Bug:  916179 
Test: app_shell_unittests, components_unittests, content_unittests
Change-Id: I2f140ebf33c7d046be44044d796aa9b05a2cc660
Reviewed-on: https://chromium-review.googlesource.com/c/1383136
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617884}
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/components/test/BUILD.gn
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/components/test/components_test_suite.cc
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/content/public/test/unittest_test_suite.cc
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/content/public/test/unittest_test_suite.h
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/extensions/BUILD.gn
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/extensions/test/DEPS
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/extensions/test/extensions_unittests_main.cc
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/ui/aura/test/aura_test_suite_setup.cc
[modify] https://crrev.com/ab78ff80ee2ffe91b1aee6ca60618bca532631a6/ui/aura/test/aura_test_suite_setup.h

Status: Fixed (was: Started)

Sign in to add a comment