Update functions that should be returning a unique_ptr instead of a raw pointer. Related ticket for net/* code: https://crbug.com/479898
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6 commit 4edb3d82520e8a3e3a7cb9df6e2eea602003adf6 Author: Ayu Ishii <ayui@chromium.org> Date: Tue Dec 18 17:29:31 2018 Change MultiProcessLock to use unique_ptr instead of raw pointers. Bug: 916176 Change-Id: I668e7b7991fb4a432245f55e9969e75623c1aab4 Reviewed-on: https://chromium-review.googlesource.com/c/1381264 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#617546} [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/multi_process_lock.h [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/multi_process_lock_linux.cc [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/multi_process_lock_mac.cc [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/multi_process_lock_unittest.cc [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/multi_process_lock_win.cc [modify] https://crrev.com/4edb3d82520e8a3e3a7cb9df6e2eea602003adf6/chrome/common/service_process_util_posix.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2392358c4e0ff0396bd74cd7c78faa45634c73d3 commit 2392358c4e0ff0396bd74cd7c78faa45634c73d3 Author: Ayu Ishii <ayui@chromium.org> Date: Tue Dec 18 23:25:41 2018 Change ClientSideDetectionHost/ClientSideDetectionService to use unique_ptr instead of raw pointers. Bug: 916176 Change-Id: Icdd4347ccd8a78eca3067ceff0cb0f3f757a5728 Reviewed-on: https://chromium-review.googlesource.com/c/1383292 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Varun Khaneja <vakh@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#617670} [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_host.cc [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_host.h [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_host_unittest.cc [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_service.cc [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_service.h [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/client_side_detection_service_unittest.cc [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/safe_browsing_tab_observer.cc [modify] https://crrev.com/2392358c4e0ff0396bd74cd7c78faa45634c73d3/chrome/browser/safe_browsing/services_delegate_impl.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6a01a1a078f2439bbf64e675596f828a09895b90 commit 6a01a1a078f2439bbf64e675596f828a09895b90 Author: Ayu Ishii <ayui@chromium.org> Date: Wed Dec 19 16:43:46 2018 Change DevToolsEmbedderMessageDispatcher to use unique_ptr instead of raw pointers. Bug: 916176 Change-Id: I16a0504d569e7f3b9169e6d410e82f63ce2ef49f Reviewed-on: https://chromium-review.googlesource.com/c/1382701 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Reviewed-by: Daniel Cheng <dcheng@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#617853} [modify] https://crrev.com/6a01a1a078f2439bbf64e675596f828a09895b90/chrome/browser/devtools/devtools_embedder_message_dispatcher.cc [modify] https://crrev.com/6a01a1a078f2439bbf64e675596f828a09895b90/chrome/browser/devtools/devtools_embedder_message_dispatcher.h [modify] https://crrev.com/6a01a1a078f2439bbf64e675596f828a09895b90/chrome/browser/devtools/devtools_ui_bindings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0c0a16a63c39857b27cf328817bf1727e3172682 commit 0c0a16a63c39857b27cf328817bf1727e3172682 Author: Ayu Ishii <ayui@chromium.org> Date: Wed Dec 19 16:45:03 2018 Change ProxyServiceFactory to return unique_ptr instead of raw pointers. Bug: 916176 Change-Id: I0b81fad63ddecac08cf1df4adf584987a66eca3d Reviewed-on: https://chromium-review.googlesource.com/c/1382704 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#617855} [modify] https://crrev.com/0c0a16a63c39857b27cf328817bf1727e3172682/chrome/browser/net/proxy_config_monitor.cc [modify] https://crrev.com/0c0a16a63c39857b27cf328817bf1727e3172682/chrome/browser/net/proxy_config_monitor.h [modify] https://crrev.com/0c0a16a63c39857b27cf328817bf1727e3172682/chrome/browser/net/proxy_service_factory.cc [modify] https://crrev.com/0c0a16a63c39857b27cf328817bf1727e3172682/chrome/browser/net/proxy_service_factory.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/981849b3bf32debfd7a2ea19c4b2e6e6106b45d6 commit 981849b3bf32debfd7a2ea19c4b2e6e6106b45d6 Author: Ayu Ishii <ayui@chromium.org> Date: Wed Dec 19 23:06:00 2018 Change ContextMenuContentTypeFactory to use unique_ptr instead of raw pointers. Bug: 916176 Change-Id: Ib58fcd3317b351507660dcd0cd4afd7a924c7880 Reviewed-on: https://chromium-review.googlesource.com/c/1383112 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#617997} [modify] https://crrev.com/981849b3bf32debfd7a2ea19c4b2e6e6106b45d6/chrome/browser/renderer_context_menu/context_menu_content_type_factory.cc [modify] https://crrev.com/981849b3bf32debfd7a2ea19c4b2e6e6106b45d6/chrome/browser/renderer_context_menu/context_menu_content_type_factory.h [modify] https://crrev.com/981849b3bf32debfd7a2ea19c4b2e6e6106b45d6/chrome/browser/renderer_context_menu/context_menu_content_type_unittest.cc [modify] https://crrev.com/981849b3bf32debfd7a2ea19c4b2e6e6106b45d6/components/renderer_context_menu/render_view_context_menu_base.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/75cc106c657f5411d5a3b738c09b1880a72bdb41 commit 75cc106c657f5411d5a3b738c09b1880a72bdb41 Author: Ayu Ishii <ayui@chromium.org> Date: Tue Jan 08 01:27:37 2019 Change ChildProcessHost to return unique_ptr instead of raw pointers Bug: 916176 Change-Id: I3d2415da9fe4edfb2a4f44a9eee40c7490c22ebb Reviewed-on: https://chromium-review.googlesource.com/c/1392432 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Avi Drissman <avi@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#620567} [modify] https://crrev.com/75cc106c657f5411d5a3b738c09b1880a72bdb41/chrome/service/service_utility_process_host.cc [modify] https://crrev.com/75cc106c657f5411d5a3b738c09b1880a72bdb41/content/browser/browser_child_process_host_impl.cc [modify] https://crrev.com/75cc106c657f5411d5a3b738c09b1880a72bdb41/content/common/child_process_host_impl.cc [modify] https://crrev.com/75cc106c657f5411d5a3b738c09b1880a72bdb41/content/public/common/child_process_host.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/2a8d0d3bf84178c0f127ab957c8395c7a32776a9 commit 2a8d0d3bf84178c0f127ab957c8395c7a32776a9 Author: Ayu Ishii <ayui@chromium.org> Date: Tue Jan 08 01:45:58 2019 Change BrowserProcessImpl to use unique_ptr instead of raw pointers Bug: 916176 Change-Id: I5d39fea96f275fc9065c5656227902837a28f0f8 Reviewed-on: https://chromium-review.googlesource.com/c/1393333 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#620573} [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/browser_process_impl.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge.h [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge_android.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge_chromeos.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge_linux.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge_mac.mm [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_platform_bridge_win.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_ui_manager.h [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/notifications/notification_ui_manager_impl.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/status_icons/status_tray.h [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/ui/android/status_tray_android.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/ui/cocoa/status_icons/status_tray_mac.mm [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/ui/views/status_icons/status_tray_linux.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/browser/ui/views/status_icons/status_tray_win.cc [modify] https://crrev.com/2a8d0d3bf84178c0f127ab957c8395c7a32776a9/chrome/test/base/testing_browser_process.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/55ed1ac4fc073bcfc9dc0538bd48455350d71c29 commit 55ed1ac4fc073bcfc9dc0538bd48455350d71c29 Author: Ayu Ishii <ayui@chromium.org> Date: Wed Jan 09 01:54:53 2019 DevToolsFrontendHost::Create to return unique_ptr instead of raw pointer Bug: 916176 Change-Id: I86967df61ccd4e322319ba2544d6bc479ddea188 Reviewed-on: https://chromium-review.googlesource.com/c/1396614 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#620994} [modify] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/chrome/browser/devtools/devtools_ui_bindings.cc [modify] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/content/browser/devtools/devtools_frontend_host_impl.cc [modify] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/content/public/browser/devtools_frontend_host.h [modify] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/content/shell/browser/shell_devtools_bindings.cc [modify] https://crrev.com/55ed1ac4fc073bcfc9dc0538bd48455350d71c29/content/shell/browser/web_test/devtools_protocol_test_bindings.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/ca7e10f59008971f9480da5ecf6606b3a421519a commit ca7e10f59008971f9480da5ecf6606b3a421519a Author: Ayu Ishii <ayui@chromium.org> Date: Thu Jan 10 22:14:30 2019 ExtensionUninstallDialog::Create to return unique_ptr instead of raw pointer Bug: 916176 Change-Id: I24bc97c2941fb9b87fd19432090db710b9844a4f Reviewed-on: https://chromium-review.googlesource.com/c/1396709 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#621775} [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/extensions/api/management/chrome_management_api_delegate.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/extensions/extension_context_menu_model.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/extensions/extension_disabled_ui.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/extensions/extension_storage_monitor.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/extensions/extension_uninstall_dialog.h [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/app_list/extension_uninstaller.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/extensions/hosted_app_browser_controller.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/views/apps/app_info_dialog/app_info_footer_panel.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/views/extensions/extension_uninstall_dialog_view_browsertest.cc [modify] https://crrev.com/ca7e10f59008971f9480da5ecf6606b3a421519a/chrome/browser/ui/webui/ntp/app_launcher_handler.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc1bd0d1bd9372e035d07444eaf7e2eb96839489 commit bc1bd0d1bd9372e035d07444eaf7e2eb96839489 Author: Ayu Ishii <ayui@chromium.org> Date: Fri Jan 11 01:37:41 2019 ProfileShortcutManager::Create to return unique_ptr instead of raw pointer Bug: 916176 Change-Id: I51812faff5892c8fb1ae4ea1c4be283b5b5014c2 Reviewed-on: https://chromium-review.googlesource.com/c/1396669 Commit-Queue: Ayu Ishii <ayui@chromium.org> Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#621854} [modify] https://crrev.com/bc1bd0d1bd9372e035d07444eaf7e2eb96839489/chrome/browser/profiles/profile_manager.cc [modify] https://crrev.com/bc1bd0d1bd9372e035d07444eaf7e2eb96839489/chrome/browser/profiles/profile_shortcut_manager.h [modify] https://crrev.com/bc1bd0d1bd9372e035d07444eaf7e2eb96839489/chrome/browser/profiles/profile_shortcut_manager_stub.cc [modify] https://crrev.com/bc1bd0d1bd9372e035d07444eaf7e2eb96839489/chrome/browser/profiles/profile_shortcut_manager_unittest_win.cc [modify] https://crrev.com/bc1bd0d1bd9372e035d07444eaf7e2eb96839489/chrome/browser/profiles/profile_shortcut_manager_win.cc
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/3b94cb817faeabdfc8b896852124b3be46cac374 commit 3b94cb817faeabdfc8b896852124b3be46cac374 Author: Ayu Ishii <ayui@chromium.org> Date: Fri Jan 11 17:33:08 2019 Change TabStyle to return unique_ptr instead of raw pointers. Bug: 916176 Change-Id: Ic2ff27655cec1a3ec4991a468710449b62457d80 Reviewed-on: https://chromium-review.googlesource.com/c/1392272 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: Allen Bauer <kylixrd@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#622050} [modify] https://crrev.com/3b94cb817faeabdfc8b896852124b3be46cac374/chrome/browser/ui/views/tabs/tab.cc [modify] https://crrev.com/3b94cb817faeabdfc8b896852124b3be46cac374/chrome/browser/ui/views/tabs/tab_style.cc [modify] https://crrev.com/3b94cb817faeabdfc8b896852124b3be46cac374/chrome/browser/ui/views/tabs/tab_style.h
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/4e19b5f1904d192dab37bd48d95bd2f8674063f1 commit 4e19b5f1904d192dab37bd48d95bd2f8674063f1 Author: Ayu Ishii <ayui@chromium.org> Date: Wed Jan 16 23:22:00 2019 Change BrowserMainRunner to return unique_ptr instead of raw pointer Bug: 916176 Change-Id: I7b08ae00471ebe5e0d4afda46a5be8143241afeb Reviewed-on: https://chromium-review.googlesource.com/c/1409516 Reviewed-by: Clark DuVall <cduvall@chromium.org> Reviewed-by: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#623441} [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/android_webview/lib/aw_main_delegate.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/chrome/app/android/chrome_main_delegate_android.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/chromecast/app/cast_main_delegate.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/content/browser/browser_main_runner_impl.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/content/browser/browser_main_runner_impl.h [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/content/public/browser/browser_main_runner.h [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/content/shell/app/shell_main_delegate.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/headless/lib/headless_content_main_delegate.cc [modify] https://crrev.com/4e19b5f1904d192dab37bd48d95bd2f8674063f1/webrunner/browser/webrunner_browser_main.cc
Comment 1 by bugdroid1@chromium.org
, Dec 18