New issue
Advanced search Search tips

Issue 916159 link

Starred by 2 users

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 1
Type: Bug



Sign in to add a comment

ios_chrome_integration_egtests (iPad Air 2 iOS 11.4) Failure ios_chrome_ui_egtests (iPad Air 2 iOS 11.4) timeout on ios-simulator-full-configs

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Dec 18

Issue description

Components: Infra>Client>iOS Test>iOS
Cc: stkhapugin@chromium.org
Labels: -Sheriff-Chromium OS-iOS Type-Bug
Status: Untriaged (was: Available)
+ios sheriff
Cc: -stkhapugin@chromium.org gambard@chromium.org
This is more general than just chrome_integration_egtests. Lot of tests are failing with timeout. More probably an issue with bots?
Cc: sergeybe...@chromium.org jbudorick@chromium.org
Labels: -Pri-2 Pri-1
Owner: jlebel@chromium.org
Status: Assigned (was: Untriaged)
It seems to time out on SigninInteractionControllerTestCase/testSignInOneUser - not sure though. jlebel@ can you ptal?

cc'ing jbudorick and sergey in case this is related to other timeouts.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 18 (4 days ago)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2a974e5ae5d7df2535b2923999f48a075d5394a8

commit 2a974e5ae5d7df2535b2923999f48a075d5394a8
Author: Gabriel Charette <gab@chromium.org>
Date: Fri Jan 18 17:20:53 2019

Revert "[ios] Call LoadIfNecessary even when displaying the NTP."

This reverts commit ddf184b056b4c7ddd8e1bd697c17924b6b50ed58.

Reason for revert: suspect for crbug.com/916159
(only ios CL in range : https://chromium.googlesource.com/chromium/src/+log/638e15167f366f1808c9122577ab881d18b25331..b485a9cce7a08fad618603f6759cc3167b540b8f?pretty=fuller&n=10000)

Original change's description:
> [ios] Call LoadIfNecessary even when displaying the NTP.
> 
> WKBasedNavigationManagerImpl::Restore will never actually begin loading
> if the current page is an NTP.  Call LoadIfNecessary to begin restore
> process.
> 
> Change-Id: Iebcfee2680ca665ebdb15883772fc042366eac58
> Reviewed-on: https://chromium-review.googlesource.com/c/1419497
> Commit-Queue: Justin Cohen <justincohen@chromium.org>
> Reviewed-by: Danyao Wang <danyao@chromium.org>
> Reviewed-by: Eugene But <eugenebut@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#623950}

TBR=justincohen@chromium.org,eugenebut@chromium.org,danyao@chromium.org

Bug: 916159
Change-Id: I7fc9766b397c97a774354d9cb28d3b38be4e5594
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/c/1422004
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Gabriel Charette <gab@chromium.org>
Cr-Commit-Position: refs/heads/master@{#624175}
[modify] https://crrev.com/2a974e5ae5d7df2535b2923999f48a075d5394a8/ios/chrome/browser/ui/browser_view_controller.mm

Comment 8 by gab@chromium.org, Jan 18 (4 days ago)

Owner: justincohen@chromium.org
Revert in r624175 fixed this.

Comment 9 by pnoland@chromium.org, Jan 18 (4 days ago)

Labels: -Sheriff-Chromium

Comment 10 by justincohen@chromium.org, Today (13 hours ago)

Owner: ----
Status: Available (was: Assigned)
There's definitely something going on with  ddf184b056b4c7d and 18cfd8ad35095 wrt testSignInSwitchManagedAccount, but none of this is related to ios_chrome_ui_egtests timetouts.  

Marking this bug as available. 

Sign in to add a comment