New issue
Advanced search Search tips

Issue 916132 link

Starred by 2 users
Status: Assigned
Owner:
k...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Incorrect usage of <ph> tag in omnibox string

Project Member Reported by dullweber@google.com, Dec 18 
In https://crrev.com/c/1106706 and https://crrev.com/c/1185300, these strings were added to omnibox_strings.grdp:

<message name="IDS_ACC_TAB_SWITCH_SUFFIX" desc="Suffix for tab switch suggestions to explain keystroke used to switch.">
    <ph name="TAB_SWITCH_SUFFIX">$1, currently open, press tab then enter to switch to the open tab</ph>
</message>
<!-- Accessibility prefix for suggestions where the tab switch button is focused. Commas are important as they add pauses. -->
<message name="IDS_ACC_TAB_SWITCH_BUTTON_FOCUSED_PREFIX" desc="Announcement when tab switch button focused.">
    <ph name="TAB_SWITCH_FOCUSED_FRIENDLY_MATCH_TEXT">Tab switch button, press enter to switch to the open tab, $1<ex>The Chromium Projects http://www.chromium.org bookmark</ex></ph>
</message>

They have a <ph> tag around the whole text but <ph> tags should only be applied to the placeholder.
In TC, it looks like the text doesn't get translated properly: http://tc/ChromeClient/3948874717360637866

Comment 1 by dullweber@google.com, Dec 18

Description: Show this description
Project Member

Comment 2 by bugdroid1@chromium.org, Dec 18 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/b34461aeeeac8cea704cee51ba7caa1c15e13b94

commit b34461aeeeac8cea704cee51ba7caa1c15e13b94
Author: Kevin Bailey <krb@chromium.org>
Date: Tue Dec 18 18:30:51 2018

[omnibox] Shorten placeholder in several messages

Placeholder tags are only supposed to cover the template argument.

Bug: 916132
Change-Id: Icc3fe3b937a47809fbd0235daa7b2c6912d6536b
Reviewed-on: https://chromium-review.googlesource.com/c/1382754
Commit-Queue: Kevin Bailey <krb@chromium.org>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617571}
[modify] https://crrev.com/b34461aeeeac8cea704cee51ba7caa1c15e13b94/components/omnibox_strings.grdp

Comment 3 by mpear...@chromium.org, Dec 18

Status: Assigned (was: Untriaged)
►

Sign in to add a comment