Credendial provider should disable itself when not starting up correctly |
||
Issue descriptionIf the credential provider is incapable of successfully completing its boot up sequence then it should disable itself. In this case "successfully completing its boot up sequence" means that the Windows welcome screen is available and a person can use any installed credential provider to sign in. It is not a boot up sequence failure if the credential provider fails only when the user begins interacting with it. A failed boot up sequence occurs when the Windows welcome screen is not functioning.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c91b6a87450ee0d00f11722da783ddd778bd09ed commit c91b6a87450ee0d00f11722da783ddd778bd09ed Author: Tien Mai <tienmai@chromium.org> Date: Wed Dec 19 22:18:19 2018 Ensure GCPW does not crash winlogon continuously. Write a to a sentinel file every time GCPW is started and keep appending to that file. If the file size reaches a maximum length (maximum consecutive crashes) then disable GCPW until this file is deleted. When GCPW reaches a state where it is considered that the user can provide input to winlogon UI then delete the sentinel file. Bug: 916129 Change-Id: If78b04f335d601970ce40968338697e81d2a211d Reviewed-on: https://chromium-review.googlesource.com/c/1384925 Commit-Queue: Tien Mai <tienmai@chromium.org> Reviewed-by: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#617976} [modify] https://crrev.com/c91b6a87450ee0d00f11722da783ddd778bd09ed/chrome/credential_provider/gaiacp/dllmain.cc [modify] https://crrev.com/c91b6a87450ee0d00f11722da783ddd778bd09ed/chrome/credential_provider/gaiacp/gaia_credential_base.cc [modify] https://crrev.com/c91b6a87450ee0d00f11722da783ddd778bd09ed/chrome/credential_provider/gaiacp/gcp_utils.cc [modify] https://crrev.com/c91b6a87450ee0d00f11722da783ddd778bd09ed/chrome/credential_provider/gaiacp/gcp_utils.h
,
Dec 20
,
Dec 27
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0e532321dccdafb2f6ddd7189354cc48c4cf6257 commit 0e532321dccdafb2f6ddd7189354cc48c4cf6257 Author: Tsuyoshi Horo <horo@chromium.org> Date: Thu Dec 27 09:18:58 2018 Add version_header in deps of chrome/credential_provider/gaiacp:common crrev.com/c/1384925 introduced #include "chrome/common/chrome_version.h" in gcp_utils.cc But version_header was not set to deps of BUILD.gn. This is causing build flakiness. TBR=rogerta@chromium.org Bug: 916129 Change-Id: I3fb7dcc2f9eeaaf76ff64e22794c6252929edb59 Reviewed-on: https://chromium-review.googlesource.com/c/1390787 Reviewed-by: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#619018} [modify] https://crrev.com/0e532321dccdafb2f6ddd7189354cc48c4cf6257/chrome/credential_provider/gaiacp/BUILD.gn |
||
►
Sign in to add a comment |
||
Comment 1 by tienmai@chromium.org
, Dec 19Status: Started (was: Untriaged)