keywords: clipboard suggestion, clipboard provider, pasteboard, paste board

Also see bug 703076, which somewhat overlaps this one (in a way that can conflict).

@martijnb, @pschaffner. What do you guys thing about bug 703076. We could try to do that for omnibox, but I feel like it'd be confusing if it's everywhere we try to paste a link in.

Now we are adding support for quickly searching based on strings in ones clipboard. 
See: https://docs.google.com/presentation/d/17rpwnmqo2AcXuIlPqb8OBjp2s8O6XzM4dcYQEVZrTts/edit#slide=id.g49fff934ea_0_169

Because of that I think we won't have to parse out the first URL anymore, but instead keep it as a String, since we aren't completely sure that the Text in the clipboard is useless.  

I assume you're willing to follow the new-feature launch process for this? In addition to getting the usual approvals, we (omnibox team) will want to to run an experiment. Presenting these suggestions any time there's anything on the clipboard will distract the user from other zero suggestions and from starting typing. The value of this may outweigh the cost but we'll want to evaluate that.

Yup, we're going to go thorough the feature launch process for this. We can let you know when that starts.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e6915ce14778cca95b3d064857d07aeb9a8718ee

commit e6915ce14778cca95b3d064857d07aeb9a8718ee
Author: Robbie Gibson <rkgibson@google.com>
Date: Wed Dec 26 12:08:10 2018

[iOS] Add copied text autocomplete to omnibox

This CL adds autocompletion for copied text to omnibox similar to copied
urls. The name of the class should probably be changed from
ClipboardURLProvider to something more generic as it now handles all
clipboard autocompletion, but that can come in a later CL.

Bug:  916120 
Change-Id: I6c6ee7b6b3ae6399cddb0a8fe3f66ed774215c0e
Reviewed-on: https://chromium-review.googlesource.com/c/1382416
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Sylvain Defresne <sdefresne@chromium.org>
Reviewed-by: Stepan Khapugin <stkhapugin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#618922}
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox/browser/clipboard_url_provider.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox/browser/clipboard_url_provider.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox/browser/clipboard_url_provider_unittest.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox/browser/omnibox_field_trial.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox/browser/omnibox_field_trial.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/omnibox_strings.grdp
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_generic.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_generic.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_generic_unittest.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_impl_ios.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_impl_ios.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_ios.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_ios.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/clipboard_recent_content_ios_unittest.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/fake_clipboard_recent_content.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/components/open_from_clipboard/fake_clipboard_recent_content.h
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/about_flags.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/location_bar/location_bar_view_controller.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/omnibox/omnibox_view_controller.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/popup_menu/BUILD.gn
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/popup_menu/popup_menu_action_handler.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/popup_menu/popup_menu_mediator.mm
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/ui_feature_flags.cc
[modify] https://crrev.com/e6915ce14778cca95b3d064857d07aeb9a8718ee/ios/chrome/browser/ui/ui_feature_flags.h

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a249a05598ffc8377b619639f2f7773de8992f6a

commit a249a05598ffc8377b619639f2f7773de8992f6a
Author: Robbie Gibson <rkgibson@google.com>
Date: Wed Jan 02 10:27:48 2019

[iOS] Update copied text styling and translation images

This CL fixes things that were unfixed in the previous CL
1382416. It changes the styling on the text match and adds the
SHA's for the images for the two new strings added in that CL.

Bug:  916120 
Change-Id: Id08ceeaa83fbacca2beb5bcd5af94a916646a883
Reviewed-on: https://chromium-review.googlesource.com/c/1390014
Commit-Queue: Robbie Gibson <rkgibson@google.com>
Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619384}
[modify] https://crrev.com/a249a05598ffc8377b619639f2f7773de8992f6a/components/omnibox/browser/clipboard_url_provider.cc
[add] https://crrev.com/a249a05598ffc8377b619639f2f7773de8992f6a/components/omnibox_strings_grdp/IDS_COPIED_TEXT_FROM_CLIPBOARD.png.sha1
[add] https://crrev.com/a249a05598ffc8377b619639f2f7773de8992f6a/components/omnibox_strings_grdp/IDS_TEXT_FROM_CLIPBOARD.png.sha1