Regression:Separator line is not seen between upper-strip and window on created shortcut window. |
||||||
Issue descriptionChrome Version: 73.0.3644.0 (Official Build) fe72396229ba179b91d835591ff0cffb311d8076-refs/branch-heads/3644@{#1} (32/64 Bit). OS : Mac(10.13.6, 10.13.1, 10.14.2), Windows(7,8,10) and Linux(14.04 LTS). Steps to reproduce: 1. Launch chrome and Navigate to youtube.com. 2. Open wrench menu and under 'More Tools' ,click on 'Create Shortcut'. 3.'Create Shortcut' Dialogue will open ,check the 'Open as window' option. 4. Navigate to chrome://apps and click on Youtube shortcut and observe. Actual Result : Separator line is not seen between upper-strip and window on created shortcut window. Expected Result : Separator line should be seen between upper-strip and window on created shortcut window. This is a regression issue broken in M-73 and will soon update bisect information: Good Build :73.0.3643.0 Bad Build : 73.0.3644.0 Note : In Windows(7,8,10) and Linux(14.04 LTS) thick Black line is seen between upper-strip and window . Kindly refer the attached screen-cast. https://drive.google.com/open?id=1bbplhs2o4gvH9jbeGv9lLb8gPKd4ci8o Thank You..
,
Dec 18
Update : Bisect-info: https://chromium.googlesource.com/chromium/src/+log/e53b4732fadd692a8335ce3f7a505f2557f57537..6010bf8377ca8a8958f713152f64e74254139b5b?pretty=fuller&n=10000 Suspect:https://chromium.googlesource.com/chromium/src/+/c77b0235fe8e67c60160fadcf5ce4c40b0563343 @Dana Fried:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: 1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again) 2. Hence providing suspect via perform Chromium bisect . Thank You...
,
Dec 18
,
Dec 18
I will take a look a this and see if it is a result of the changes.
,
Dec 18
,
Dec 18
The real bug here is that the browser is reserving space for the toolbar while it is not showing the toolbar.
,
Dec 19
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/5c6c67597ad28aca94ab863e05f436f5d32ac556 commit 5c6c67597ad28aca94ab863e05f436f5d32ac556 Author: Dana Fried <dfried@chromium.org> Date: Wed Dec 19 03:16:10 2018 Fix toolbar animation/hide. Toolbar was not hiding properly because we did not respect animation logic with new layout manager. Fix was to animate preferred and minimum size with animation, as before. Bug: 916106 Change-Id: Iffb4344399a0a6f8c80f34f78d432b03dad7f1fd Reviewed-on: https://chromium-review.googlesource.com/c/1383402 Reviewed-by: Peter Boström <pbos@chromium.org> Commit-Queue: Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#617716} [modify] https://crrev.com/5c6c67597ad28aca94ab863e05f436f5d32ac556/chrome/browser/ui/views/toolbar/toolbar_view.cc [modify] https://crrev.com/5c6c67597ad28aca94ab863e05f436f5d32ac556/chrome/browser/ui/views/toolbar/toolbar_view.h
,
Dec 19
You're welcome! I HATE regressions :)
,
Dec 19
,
Dec 20
Update: Retested above issue on Mac(10.13.1 , 10.13.6 , 10.14.2) OS using latest Canary #73.0.3646.0 issue is fixed. Now,Separator line is seen between upper-strip and window on created shortcut window. Kindly review the attached screen-cast. https://drive.google.com/open?id=1-Ps33isrtAQel2ILFOoD1qc5_mJL47Rh Thank you! |
||||||
►
Sign in to add a comment |
||||||
Comment 1 by rbasuvula@chromium.org
, Dec 18Status: Untriaged (was: Unconfirmed)