Regression: Unable to exit the video from full screen mode after clicking on full screen icon |
|
Issue descriptionChrome Version:72.0.3626.23 (Official Build) Revision 61ac8cabff274b3293e9c208ff874a70e3023f2c-refs/branch-heads/3626@{#416} (32/64-bit) OS: Mac(10.13.1 , 10.13.6 , 10.14.2), Linux(14.04 LTS) and Windows(7,8,10) OS. Test URL: https://www.izlesene.com/video/kardes-aslanlar-timsahin-saldirisina-ugradi/10379675 Steps to reproduce: 1. Launch chrome, navigate to 'https://izlesene.com' and play any video (for reference navigate to above test URL). 2. Enter the video into full-screen mode from full screen icon on video. 3. Now, try to exit the video from full screen using the full screen icon and Observe. Actual Result : Unable to exit the video from full screen mode after clicking on full screen icon. Expected Result : Should be able to exit the video from full screen mode after clicking on full screen icon. This is a regression issue broken in M-71 and below is the chromium bisect information: Good Build : 71.0.3544.0 (Revision : 589077) Bad Build : 71.0.3545.0(Revision : 589377) You are probably looking for a change made after 589184 (known good), but no later than 589185 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/d567caa14b94d1bac1d72e9c4dac9b7458786629..62898a131761fbeeac3f2b2f7c2c0512f7ca14a9 Suspecting: https://chromium.googlesource.com/chromium/src/+/62898a131761fbeeac3f2b2f7c2c0512f7ca14a9 @Dave:Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Issue is also reproducible on latest Dev #73.0.3642.0 & Canary #73.0.3644.0 Kindly refer the attached screencast. Thank You!
,
Dec 19
Just to Update, checked the above issue on other browsers (Mozilla Firefox and Safari) and observed that issue is not reproducible and full screen is working fine on navigating to above mentioned URL on other browsers. Attaching the screen-cast of behavior on Mozilla Firefox. @Dave: Request you to kindly look into this again. Thank You..!
,
Dec 19
sanyamg@ This is not a bug in Firefox because they always send the mozFullscreenChange event and this isn't a bug in Safari because they don't support unprefixed fullscreen API. Ultimately this is a bug in the website code that was trying to take advantage of a new API before we even shipped it. And once the new API is available their logic was untested and incorrect. This is easily fixed on their end.
,
Dec 20
@sanyamg: Thank you for the report! @Dave: Thanks for taking time and bringing this to our attention! We are now also listening for the unprefixed version of the event and it works properly: https://www.izlesene.com/video/kardes-aslanlar-timsahin-saldirisina-ugradi/10379675 Cheers!
,
Dec 20
mert@ Thanks for following up and glad you were able to fix this in short order. |
|
►
Sign in to add a comment |
|
Comment 1 by dtapu...@chromium.org
, Dec 18This is a website issue. They are providing their own implementation of the fullscreen control. The problem is they aren't listening to the fullscreenchange event and are binding to only the prefixed versions. ie: document.addEventListener("webkitfullscreenchange", screenHandler); They should add: document.addEventListener("fullscreenchange", screenHandler); if they are going to call the unprefixed request fullscreen event.