New issue
Advanced search Search tips

Issue 916092 link

Starred by 3 users
Status: Fixed
Owner:
dfried@chromium.org
Closed: Dec 19
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
dfried@chromium.org
dpa...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: Home button bottom line appears thin on first instance.

Project Member Reported by aim...@virtusa.com, Dec 18 
Chrome Version: 73.0.3644.0 (Official Build) fe72396229ba179b91d835591ff0cffb311d8076-refs/branch-heads/3644@{#1} (32/64 Bit).

OS: Windows(7,8,8.1,10)

What steps will reproduce the problem?
1. Freshly install and Launch chrome, navigate to chrome://settings/appearance
2. Click on Show home button bar.
4. Observe home button in omnibox.

Actual Result: Home button bottom line appears thin on first instance.
Expected Result: Bottom line should appear of proper width.

This is a regression issue, broken in M-73 series, and will soon update other info:

Good Build: 73.0.3643.0.0(Revision: 617033)
Bad Build: 73.0.3644.0(Revision: 617389)
Actual Result.mp4
426 KB View Download
Actual Result.png
127 KB View Download
Expected Result.mp4
457 KB View Download

Comment 1 by aim...@virtusa.com, Dec 18

Labels: hasbisect OS-Linux
Owner: dfried@chromium.org
Status: Assigned (was: Unconfirmed)
Hi

Update:

Below is the Bisect-info:

Change-Log URL: 

https://chromium.googlesource.com/chromium/src/+log/e53b4732fadd692a8335ce3f7a505f2557f57537..6010bf8377ca8a8958f713152f64e74254139b5b?pretty=fuller&n=10000

Suspecting: r617299 ?

dfried@: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note: 
1. Unable to provide 'per-revision' bisect as it shows "We don't have enough builds to bisect" error message for above range. (tried on other machines but still getting the same error again)
2. Hence providing suspect via perform Chromium bisect .
3. Issue is also reproducible on Linux(14.04 LTS) and is  not seen on Mac(10.13.1, 10.13.6, 10.14.2) OS

Thank You!

Comment 2 by dfried@chromium.org, Dec 18 

This is a weird one but I'll take a whack at it.

Comment 3 by dfried@chromium.org, Dec 18

Status: Started (was: Assigned)

Comment 4 by dfried@chromium.org, Dec 19

Cc: dfried@chromium.org
 Issue 916415  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1379fbc9bc73b39541c0d5a2af5d6f24a83e903a

commit 1379fbc9bc73b39541c0d5a2af5d6f24a83e903a
Author: Dana Fried <dfried@chromium.org>
Date: Wed Dec 19 22:53:14 2018

Fix home button glitch.

Home button was not set to its preferred size before it was added to the
toolbar, which resulted in its image getting cut off when it was first
rendered after being hidden.

This CL also changes when we set the visibility of the home button
from every time we do ToolbarView::Layout() to only when its visibility
actually changes.

Bug:  916092 
Change-Id: I5f680536d76f629faf2712dcfa3cf1aa527d1e04
Reviewed-on: https://chromium-review.googlesource.com/c/1382958
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#617993}
[modify] https://crrev.com/1379fbc9bc73b39541c0d5a2af5d6f24a83e903a/chrome/browser/ui/views/toolbar/toolbar_view.cc
[modify] https://crrev.com/1379fbc9bc73b39541c0d5a2af5d6f24a83e903a/chrome/browser/ui/views/toolbar/toolbar_view.h

Comment 6 by dfried@chromium.org, Dec 19

Status: Fixed (was: Started)

Comment 7 by aim...@virtusa.com, Dec 20

Labels: TE-Verified-M73 TE-Verified-73.0.3646.0
Hi,

Update:

Retested the above issue on Windows(7,8,8.1,10) and Linux (14.04 LTS) OS using latest Canary build #73.0.3646.0 and issue is fixed.

Now, Home button bottom line is appearing of proper width.

Kindly refer the below attached screen-cast.

Thank You!
Canary Behaviour.mp4
554 KB View Download
►

Sign in to add a comment