New issue
Advanced search Search tips

Issue 916077 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

ul in nav cut off when expanded on hover

Reported by adam.war...@raisingit.com, Dec 18

Issue description

UserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:66.0) Gecko/20100101 Firefox/66.0

Steps to reproduce the problem:
1. Head to this site https://www.afghanaid.org.uk/ (There are a few others that exibit the same issue but which are not public.)
2. Hover over one of the top level navigation menu items in Chrome 70+
3. 

What is the expected behavior?
Submenu should fully expand.

What went wrong?
Submenu is cut off for no apparent reason.

Did this work before? Yes 69

Chrome version: 73.0.3643.0  Channel: canary
OS Version: 10.0
Flash Version: 

I've tried adjusting z-index on these elements, but that does not help. Inspecting them shows that there is no obvious reason why they're not visible past a certain point.

If anyone has any ideas, please let me know.
 
JheTVu.png
162 KB View Download
Bisected to r582337 = 46520ae13478333fe882e79041b667e5a3112796 = https://crrev.com/c/1168142 by chrishtr@chromium.org
"[PE] Stop dirtying compositing inputs on any layout for the root PaintLayer."
Landed in 70.0.3519.0

Components: Blink>Paint>Invalidation
Labels: Needs-Triage-M73 Needs-Bisect
Cc: vamshi.kommuri@chromium.org
Labels: -Type-Bug -Pri-2 -Needs-Bisect RegressedIn-70 Target-73 Triaged-ET Target-71 Target-72 FoundIn-72 M-73 FoundIn-71 FoundIn-73 hasbisect OS-Mac Pri-1 Type-Bug-Regression
Owner: chrishtr@chromium.org
Status: Assigned (was: Unconfirmed)
Thanks for filing the issue!

Able to reproduce the issue on reported chrome version 73.0.3643.0 using Windows 10 and Mac 10.14.1
Note: Issue isn't seen on Ubuntu 14.04

Bisect Information:
-------------------
Good Build: 70.0.3518.0
Bad Build:  70.0.3519.0

From comment#1 suspecting the same.
Change Log:
https://chromium.googlesource.com/chromium/src/+/46520ae13478333fe882e79041b667e5a3112796
Review URL: https://chromium-review.googlesource.com/1168142

@Chris Harrelson: Please help in assigning it to the right owner if this isn't related to your change.

Comment 5 Deleted

It's because of a backface-visibility: hidden element, which confuses the
system.
Project Member

Comment 7 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/722a913a012145a221973945fd9411ad6444ccd2

commit 722a913a012145a221973945fd9411ad6444ccd2
Author: Chris Harrelson <chrishtr@chromium.org>
Date: Thu Jan 03 22:29:15 2019

[PE] Set GraphicsLayerUpdate bits on the enclosing stacking composited layer.

This ensures that we will paper over any confusions regarding non-stacking
composited layers such as as those created by backface-visibility: hidden.

Setting the bit on the enclosing stacking layer suffices because any
other composited layer must be a stacking child of it, and the
kGraphicsLayerUpdateSubtree is used.

Bug:  916077 

Change-Id: I695f9b7a6700e1bed3bc55034916b200a1d7849e
Reviewed-on: https://chromium-review.googlesource.com/c/1394187
Reviewed-by: Xianzhu Wang <wangxianzhu@chromium.org>
Commit-Queue: Chris Harrelson <chrishtr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619787}
[modify] https://crrev.com/722a913a012145a221973945fd9411ad6444ccd2/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.cc
[modify] https://crrev.com/722a913a012145a221973945fd9411ad6444ccd2/third_party/blink/renderer/core/paint/compositing/compositing_inputs_updater.h
[modify] https://crrev.com/722a913a012145a221973945fd9411ad6444ccd2/third_party/blink/web_tests/external/wpt/css/CSS2/stacking-context/opacity-change-parent-stacking-context.html
[add] https://crrev.com/722a913a012145a221973945fd9411ad6444ccd2/third_party/blink/web_tests/external/wpt/css/css-transforms/size-change-under-backface-visibility-hidden-ref.html
[add] https://crrev.com/722a913a012145a221973945fd9411ad6444ccd2/third_party/blink/web_tests/external/wpt/css/css-transforms/size-change-under-backface-visibility-hidden.html

Status: Fixed (was: Assigned)

Sign in to add a comment