New issue
Advanced search Search tips

Issue 916074 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Perfetto: Support building on missing platforms

Project Member Reported by eseckler@chromium.org, Dec 18

Issue description

I believe that's Fuchsia only? Maybe iOS, too?
 
iOS as well yes, at least tracing builds there (though I have no idea how much it's used in practice).
my very handwavy expectation about iOS: 90% of it should JustWork because Mac JustWorks™. The remaining 10% will be due to the fact that page sizes on iOS are not necessarily 4096 bytes. I remember discovering that in the context of Issue 542671 
Project Member

Comment 3 by bugdroid1@chromium.org, Jan 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c01be60ed485f3fb645453f4c84a373ebf4cdf44

commit c01be60ed485f3fb645453f4c84a373ebf4cdf44
Author: Eric Seckler <eseckler@chromium.org>
Date: Thu Jan 03 09:17:02 2019

perfetto: Build on Fuchsia

perfetto_unittests and content_unittests seem to be passing. Other test
suites (content_browsertests / services_unittests) aren't currently
supported on Fuchsia so can't yet verify that everything works in
practice.

Depends on aosp/853409 and aosp/859117.

Bug: 916074
Change-Id: I6d7c034fdf9e3086e08b6a1338e78f75a1c86afd
Reviewed-on: https://chromium-review.googlesource.com/c/1382134
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: oysteine <oysteine@chromium.org>
Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Eric Seckler <eseckler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#619606}
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/BUILD.gn
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/services/tracing/BUILD.gn
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/services/tracing/public/cpp/BUILD.gn
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/services/tracing/public/cpp/trace_event_agent.cc
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/services/tracing/tracing_service.h
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/testing/buildbot/chromium.linux.json
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/testing/buildbot/gn_isolate_map.pyl
[modify] https://crrev.com/c01be60ed485f3fb645453f4c84a373ebf4cdf44/testing/buildbot/test_suites.pyl

Sign in to add a comment