QR code scanning text isn't readable with large font |
|||
Issue descriptioniPhone SE With Large Font. What steps will reproduce the problem? (1) Open the QR code scanner What is the expected result? The text should be readable. What happens instead? The bottom of the text is cut. Assigning to Martijn as I am not sure about how to solve this... Should we move the frame up? Not scaling the text isn't great neither.
,
Jan 4
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/36dcabf140dcf128dcdb26060d17b3553bc75d6e commit 36dcabf140dcf128dcdb26060d17b3553bc75d6e Author: Gauthier Ambard <gambard@chromium.org> Date: Fri Jan 04 12:49:05 2019 [iOS] Put the QRCode scanner caption in scrollView This CL puts the caption in a scroll view, allowing it to be scrolled when the font size is big. Bug: 916068 Change-Id: I111e1d4e00ea2949c85964999106248dfebb433c Reviewed-on: https://chromium-review.googlesource.com/c/1392187 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#619926} [modify] https://crrev.com/36dcabf140dcf128dcdb26060d17b3553bc75d6e/ios/chrome/browser/ui/qr_scanner/BUILD.gn [modify] https://crrev.com/36dcabf140dcf128dcdb26060d17b3553bc75d6e/ios/chrome/browser/ui/qr_scanner/qr_scanner_view.mm
,
Jan 4
,
Jan 8
Issue verified Version: Chrome Canary 73.0.3665.0 Device: iPhone SE iOS: 11.4.1 Readable text with larger text size https://drive.google.com/open?id=0B1z1PB9k31FgZXY1QUlBMnoxdEVVWTgteUFiU1BiSml0c2gw |
|||
►
Sign in to add a comment |
|||
Comment 1 by martijnb@chromium.org
, Dec 21Owner: gambard@chromium.org