New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 916067 link

Starred by 1 user
Status: Fixed
Owner:
jianj@chromium.org
Closed: Dec 19
Cc:
█ marpan@chromium.org
mflodman@chromium.org
sprang@chromium.org
brandtr@chromium.org
terelius@chromium.org
holmer@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Merge to M72: VP9 resets temporal prediction pattern

Project Member Reported by ssilkin@chromium.org, Dec 18 
This is a merge request for the following fix in libvpx VP9 encoder:
https://chromium.googlesource.com/webm/libvpx.git/+/15389ab11d1001749ea796e0c86b345555703d15

The issue is describe in https://bugs.chromium.org/p/webrtc/issues/detail?id=10119.

The fix needs to be merged to M72.
Project Member

Comment 1 by sheriffbot@chromium.org, Dec 18

Labels: -Merge-Request-72 Merge-Review-72 Hotlist-Merge-Review
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Comment 2 by ssilkin@chromium.org, Dec 18

Labels: OS-Chrome OS-Linux OS-Mac OS-Windows

Comment 3 by abdulsyed@google.com, Dec 18

Labels: -Merge-Review-72 Merge-Approved-72
Project Member

Comment 4 by bugdroid1@chromium.org, Dec 18

Labels: merge-merged-m72-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/webm/libvpx/+/864949ddbc88bf9b3bf63793ed925c7222c99916

commit 864949ddbc88bf9b3bf63793ed925c7222c99916
Author: Marco Paniconi <marpan@google.com>
Date: Tue Dec 18 23:15:01 2018

vp9-svc: On scene change: only reset TL in flexible mode.

On scene/slide change detected on TL > 0 frame, only
reset the temporal layer pattern for flexible/bypass mode.

Change-Id: Ib848778addc10ef6981b92839af397833fd4a908
(cherry picked from commit 15389ab11d1001749ea796e0c86b345555703d15)

BUG= 916067 , webrtc:10119 

Change-Id: Ic77afdd2de34701857634a8c0bb0025ecd5e4d8e

[modify] https://crrev.com/864949ddbc88bf9b3bf63793ed925c7222c99916/vp9/encoder/vp9_encoder.c
Project Member

Comment 5 by bugdroid1@chromium.org, Dec 19

Labels: -merge-approved-72 merge-merged-3626
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/58975ca77e93e552f63fb08143519b1a3d6cf42c

commit 58975ca77e93e552f63fb08143519b1a3d6cf42c
Author: Jerome Jiang <jianj@google.com>
Date: Wed Dec 19 00:34:16 2018

libvpx: update DEPS for m72 merge.

BUG= 916067 , webrtc:10119 
R=jzern

Change-Id: I61df2f468b2345b5d1825f82a67937849f4c7127
Reviewed-on: https://chromium-review.googlesource.com/c/1383058
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#460}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
[modify] https://crrev.com/58975ca77e93e552f63fb08143519b1a3d6cf42c/DEPS

Comment 6 by jianj@chromium.org, Dec 19

Status: Fixed (was: Assigned)
Fix has been merged into M72.
Project Member

Comment 7 by cr-audit...@appspot.gserviceaccount.com, Dec 19

Labels: Merge-Merged-72-3626
The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/58975ca77e93e552f63fb08143519b1a3d6cf42c

Commit: 58975ca77e93e552f63fb08143519b1a3d6cf42c
Author: jianj@google.com
Commiter: jzern@google.com
Date: 2018-12-19 00:34:16 +0000 UTC

libvpx: update DEPS for m72 merge.

BUG= 916067 , webrtc:10119 
R=jzern

Change-Id: I61df2f468b2345b5d1825f82a67937849f4c7127
Reviewed-on: https://chromium-review.googlesource.com/c/1383058
Reviewed-by: James Zern <jzern@google.com>
Cr-Commit-Position: refs/branch-heads/3626@{#460}
Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
►

Sign in to add a comment