Regression: Search box spinner keeps spinning forever after searching for a query. |
||||||||||||
Issue descriptionChrome Version : 73.0.3643.0 (Official Build) Revision 310dbdcb8884c1a70ee5cc78c7527778870ea067-refs/branch-heads/3643@{#1} (32/64-bit) OS : Windows (7, 8, 8.1, 10), Linux(14.04 LTS), Mac(10.13.1, 10.13.6, 10.14.3) What steps will reproduce the problem? 1. Launch chrome and navigate to chrome://settings page. 2. Type letter "a" in search box and observe the spinner. Actual Result : Search box spinner keeps spinning forever after searching for a query. Expected Result : Spinner should stop once the matching results are found. This is a regression issue broken in ‘M-73’ and below is the chromium bisect info: Good Build : 73.0.3642.0 (Revision : 616997) Bad Build : 73.0.3643.0 (Revision : 617032) You are probably looking for a change made after 617030 (known good), but no later than 617032 (first known bad). CHANGE-LOG URL: https://chromium.googlesource.com/chromium/src/+log/c8ab016f530f2e3d2556d940da6eae604e56222a..5087874631491f9b9586d33998c4c9173dce2a53 Suspecting: https://chromium.googlesource.com/chromium/src/+/5087874631491f9b9586d33998c4c9173dce2a53 @Thomas: Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner. Note: Unable to provide bisect using hasbisect-per-revision as getting the error: 'Error running the gsutil command: AccessDeniedException: 403' Kindly refer the screen cast for reference Thank You!
,
Dec 18
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/9d3e52e2ac14730d1ac60eeda90644a2f73ec57b commit 9d3e52e2ac14730d1ac60eeda90644a2f73ec57b Author: Thomas Tangl <tangltom@chromium.org> Date: Tue Dec 18 11:30:19 2018 [unified-consent] Fix settings search Make the advanced sync settings subpage non-searchable to avoid the settings search crawler from failing/crashing. Note: This is also done for /content/cookies and some other subpages with depth 2. TBR=jochen@chromium.org Bug: 916064 Change-Id: I5927e1ad29caefe2f5633f200e555d4eda9ed011 Reviewed-on: https://chromium-review.googlesource.com/c/1382132 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#617445} [modify] https://crrev.com/9d3e52e2ac14730d1ac60eeda90644a2f73ec57b/chrome/browser/resources/settings/people_page/people_page.html
,
Dec 18
,
Dec 19
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.3) using latest Canary build : 73.0.3645.0 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!!
,
Dec 19
Verified this fix on Canary and requesting merge to M72 since it's affected to.
,
Dec 19
This bug requires manual review: M72 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: govind@(Android), kariahda@(iOS), djmm@(ChromeOS), abdulsyed@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Dec 19
Merge approved M72, Branch:3626
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a21a74f9a8b49c6ba87794b683345b76e95111 commit 12a21a74f9a8b49c6ba87794b683345b76e95111 Author: Thomas Tangl <tangltom@chromium.org> Date: Thu Dec 20 14:21:01 2018 [unified-consent] Fix settings search Make the advanced sync settings subpage non-searchable to avoid the settings search crawler from failing/crashing. Note: This is also done for /content/cookies and some other subpages with depth 2. TBR=jochen@chromium.org Bug: 916064 Change-Id: I5927e1ad29caefe2f5633f200e555d4eda9ed011 Reviewed-on: https://chromium-review.googlesource.com/c/1382132 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617445}(cherry picked from commit 9d3e52e2ac14730d1ac60eeda90644a2f73ec57b) Reviewed-on: https://chromium-review.googlesource.com/c/1386867 Cr-Commit-Position: refs/branch-heads/3626@{#483} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437} [modify] https://crrev.com/12a21a74f9a8b49c6ba87794b683345b76e95111/chrome/browser/resources/settings/people_page/people_page.html
,
Dec 20
Here's a summary of the rules that were executed: - OnlyMergeApprovedChange: Rule Failed -- Revision 12a21a74f9a8b49c6ba87794b683345b76e95111 was merged to refs/branch-heads/3626 branch with no merge approval from a TPM! Please explain why this change was merged to the branch! - AcknowledgeMerge: Notification Required --
,
Dec 20
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/12a21a74f9a8b49c6ba87794b683345b76e95111 Commit: 12a21a74f9a8b49c6ba87794b683345b76e95111 Author: tangltom@chromium.org Commiter: tangltom@chromium.org Date: 2018-12-20 14:21:01 +0000 UTC [unified-consent] Fix settings search Make the advanced sync settings subpage non-searchable to avoid the settings search crawler from failing/crashing. Note: This is also done for /content/cookies and some other subpages with depth 2. TBR=jochen@chromium.org Bug: 916064 Change-Id: I5927e1ad29caefe2f5633f200e555d4eda9ed011 Reviewed-on: https://chromium-review.googlesource.com/c/1382132 Reviewed-by: Thomas Tangl <tangltom@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#617445}(cherry picked from commit 9d3e52e2ac14730d1ac60eeda90644a2f73ec57b) Reviewed-on: https://chromium-review.googlesource.com/c/1386867 Cr-Commit-Position: refs/branch-heads/3626@{#483} Cr-Branched-From: d897fb137fbaaa9355c0c93124cc048824eb1e65-refs/heads/master@{#612437}
,
Dec 26
,
Jan 9
Update : Rechecked the above issue on Windows (7,8,8.1,10),Linux (14.04 LTS),Mac OS X(10.13.1,10.13.6,10.14.3) using latest Beta build : 72.0.3626.53 and the issue is Fixed.Hence adding TE Verified Labels. Kindly refer the attached screen cast. Thank you..!! |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by tangltom@chromium.org
, Dec 18